Re: [Patch net] ipv6: reorder ip6_route_dev_notifier after ipv6_dev_notf

2017-05-04 Thread Cong Wang
On Thu, May 4, 2017 at 7:04 AM, David Ahern wrote: > On 5/3/17 11:07 PM, Cong Wang wrote: >> For each netns (except init_net), we initialize its null entry >> in 3 places: >> >> 1) The template itself, as we use kmemdup() >> 2) Code around dst_init_metrics() in ip6_route_net_init() >> 3) ip6_route

Re: [Patch net] ipv6: reorder ip6_route_dev_notifier after ipv6_dev_notf

2017-05-04 Thread David Ahern
On 5/3/17 11:07 PM, Cong Wang wrote: > For each netns (except init_net), we initialize its null entry > in 3 places: > > 1) The template itself, as we use kmemdup() > 2) Code around dst_init_metrics() in ip6_route_net_init() > 3) ip6_route_dev_notify(), which is supposed to initialize it after > l

Re: [Patch net] ipv6: reorder ip6_route_dev_notifier after ipv6_dev_notf

2017-05-04 Thread David Ahern
On 5/3/17 11:07 PM, Cong Wang wrote: > diff --git a/net/ipv6/route.c b/net/ipv6/route.c > index 2f11366..4dbf7e2 100644 > --- a/net/ipv6/route.c > +++ b/net/ipv6/route.c > @@ -4024,7 +4024,7 @@ static struct pernet_operations ip6_route_net_late_ops > = { > > static struct notifier_block ip6_rou

[Patch net] ipv6: reorder ip6_route_dev_notifier after ipv6_dev_notf

2017-05-03 Thread Cong Wang
For each netns (except init_net), we initialize its null entry in 3 places: 1) The template itself, as we use kmemdup() 2) Code around dst_init_metrics() in ip6_route_net_init() 3) ip6_route_dev_notify(), which is supposed to initialize it after loopback registers Unfortunately the last one still