Re: [Patch net] ax25: fix a use-after-free in ax25_fillin_cb()

2018-12-30 Thread David Miller
From: Cong Wang Date: Sat, 29 Dec 2018 13:56:36 -0800 > There are multiple issues here: > > 1. After freeing dev->ax25_ptr, we need to set it to NULL otherwise >we may use a dangling pointer. > > 2. There is a race between ax25_setsockopt() and device notifier as >reported by syzbot. Cl

[Patch net] ax25: fix a use-after-free in ax25_fillin_cb()

2018-12-29 Thread Cong Wang
There are multiple issues here: 1. After freeing dev->ax25_ptr, we need to set it to NULL otherwise we may use a dangling pointer. 2. There is a race between ax25_setsockopt() and device notifier as reported by syzbot. Close it by holding RTNL lock. 3. We need to test if dev->ax25_ptr is N