Hi Florian
I agree we should define this, and we can add it to
Documentation/ABI/testing/sysfs-class-net-statistics
> - BQL cares about bytes sent on the wire, so that should not include
> pre/appended descriptors nor the FCS (nor the Ethernet preamble),
> tx_bytes should be equivalent to that
C
On 05/18/2017 08:22 AM, David Miller wrote:
> From: Andrew Lunn
> Date: Thu, 18 May 2017 17:09:25 +0200
>
>> Since these are software counters, they can be consistent. From a
>> practical point of view, i doubt they ever will all be consistent,
>> there are simply too many drivers to test and cha
From: Andrew Lunn
Date: Thu, 18 May 2017 17:09:25 +0200
> Since these are software counters, they can be consistent. From a
> practical point of view, i doubt they ever will all be consistent,
> there are simply too many drivers to test and change if
> needed. However, for the ones somebody cares
> I am afraid that we won't be able to enforce a consistent behavior,
> because the HW itself is not consistent, both on the NIC and on the
> switch side.
Hi Florian
I agree with that, for MIB counters. They tend to come direct from the
hardware.
However, rx_bytes and tx_bytes are not from the h
On 05/17/2017 01:23 PM, Andrew Lunn wrote:
> The statistics counters rx_bytes and tx_bytes don't include the
> Ethernet Frame Check Sequence. The hardware appears to calculate it on
> send, so it is not part of the URB passed to the device, and on
> receive it was not being copied into the skb.
>
The statistics counters rx_bytes and tx_bytes don't include the
Ethernet Frame Check Sequence. The hardware appears to calculate it on
send, so it is not part of the URB passed to the device, and on
receive it was not being copied into the skb.
Fix the rx_bytes/tx_bytes counters, and copy the FCS
