Re: [Patch] Signedness issue in drivers/net/3c515.c

2006-08-21 Thread Alan Cox
Ar Llu, 2006-08-21 am 14:05 -0700, ysgrifennodd Andrew Morton: > /* Wait for the stall to complete. */ > for (i = 20; i >= 0; i--) > if ((inw(ioaddr + EL3_STATUS) & CmdInProgress) == 0) > break; > > Your fix will convert this indefinit wait into a b

Re: [Patch] Signedness issue in drivers/net/3c515.c

2006-08-21 Thread Andrew Morton
On Sat, 19 Aug 2006 19:37:57 +0200 Eric Sesterhenn <[EMAIL PROTECTED]> wrote: > while playing with gcc 4.1 -Wextra warnings, I came across this one: > > drivers/net/3c515.c:1027: warning: comparison of unsigned expression >= 0 is > always true > > Since i is unsigned the >= 0 check in the for l