Re: [PKT_SCHED] act_gact: division by zero

2006-12-01 Thread David Miller
From: "Nordlund Kim (Nokia-NET/Helsinki)" <[EMAIL PROTECTED]> Date: Thu, 30 Nov 2006 15:51:04 +0200 (EET) > > On Thu, 30 Nov 2006, ext Patrick McHardy wrote: > > I think it should reject an invalid configuration or handle > > the zero case correctly by not dividing. > > You are correct. Not retu

Re: [PKT_SCHED] act_gact: division by zero

2006-11-30 Thread Patrick McHardy
Nordlund Kim (Nokia-NET/Helsinki) wrote: > On Thu, 30 Nov 2006, ext Patrick McHardy wrote: > >>I think it should reject an invalid configuration or handle >>the zero case correctly by not dividing. > > > You are correct. Not returning -EINVAL, because someone might > want to use the value zero i

Re: [PKT_SCHED] act_gact: division by zero

2006-11-30 Thread Nordlund Kim (Nokia-NET/Helsinki)
On Thu, 30 Nov 2006, ext Patrick McHardy wrote: > I think it should reject an invalid configuration or handle > the zero case correctly by not dividing. You are correct. Not returning -EINVAL, because someone might want to use the value zero in some future gact_prob algorithm? Signed-off-by: Kim

Re: [PKT_SCHED] act_gact: division by zero

2006-11-30 Thread Patrick McHardy
Nordlund Kim (Nokia-NET/Helsinki) wrote: > tc qdisc add dev eth1 handle : ingress > tc filter add dev eth1 protocol ip parent : pref 99 basic \ >flowid 1:1 action pass random determ drop 0 > ^ > the above cause a division by zero in the kerne

[PKT_SCHED] act_gact: division by zero

2006-11-30 Thread Nordlund Kim (Nokia-NET/Helsinki)
tc qdisc add dev eth1 handle : ingress tc filter add dev eth1 protocol ip parent : pref 99 basic \ flowid 1:1 action pass random determ drop 0 ^ the above cause a division by zero in the kernel on the first packet in. Signed-off-by: Kim Nord