Re: [PATH net] ipv4: keep skb->dst around in presence of IP options

2017-02-04 Thread David Miller
From: Eric Dumazet Date: Sat, 04 Feb 2017 11:16:52 -0800 > From: Eric Dumazet > > Andrey Konovalov got crashes in __ip_options_echo() when a NULL skb->dst > is accessed. > > ipv4_pktinfo_prepare() should not drop the dst if (evil) IP options > are present. > > We could refine the test to the

[PATH net] ipv4: keep skb->dst around in presence of IP options

2017-02-04 Thread Eric Dumazet
From: Eric Dumazet Andrey Konovalov got crashes in __ip_options_echo() when a NULL skb->dst is accessed. ipv4_pktinfo_prepare() should not drop the dst if (evil) IP options are present. We could refine the test to the presence of ts_needtime or srr, but IP options are not often used, so let's b