Re: [PATCHv4 net] ipv6: no need to check rt->dst.error when get route info

2017-07-31 Thread David Miller
From: David Ahern Date: Mon, 31 Jul 2017 17:34:09 -0600 > On 7/31/17 5:22 PM, David Miller wrote: >> From: Hangbin Liu >> Date: Fri, 28 Jul 2017 00:25:36 +0800 >> >>> After commit 18c3a61c4264 ("net: ipv6: RTM_GETROUTE: return matched fib >>> result when requested"). When we get a prohibit ertr

Re: [PATCHv4 net] ipv6: no need to check rt->dst.error when get route info

2017-07-31 Thread David Ahern
On 7/31/17 5:22 PM, David Miller wrote: > From: Hangbin Liu > Date: Fri, 28 Jul 2017 00:25:36 +0800 > >> After commit 18c3a61c4264 ("net: ipv6: RTM_GETROUTE: return matched fib >> result when requested"). When we get a prohibit ertry, we will return >> -EACCES directly instead of dump route info.

Re: [PATCHv4 net] ipv6: no need to check rt->dst.error when get route info

2017-07-31 Thread David Miller
From: Hangbin Liu Date: Fri, 28 Jul 2017 00:25:36 +0800 > After commit 18c3a61c4264 ("net: ipv6: RTM_GETROUTE: return matched fib > result when requested"). When we get a prohibit ertry, we will return > -EACCES directly instead of dump route info. > > Fix it by remove the rt->dst.error check. .

Re: [PATCHv4 net] ipv6: no need to check rt->dst.error when get route info

2017-07-28 Thread David Ahern
On 7/27/17 12:03 PM, David Ahern wrote: > On 7/27/17 10:25 AM, Hangbin Liu wrote: >> After commit 18c3a61c4264 ("net: ipv6: RTM_GETROUTE: return matched fib >> result when requested"). When we get a prohibit ertry, we will return >> -EACCES directly instead of dump route info. >> >> Fix it by remov

Re: [PATCHv4 net] ipv6: no need to check rt->dst.error when get route info

2017-07-27 Thread Roopa Prabhu
On Thu, Jul 27, 2017 at 9:25 AM, Hangbin Liu wrote: > After commit 18c3a61c4264 ("net: ipv6: RTM_GETROUTE: return matched fib > result when requested"). When we get a prohibit ertry, we will return > -EACCES directly instead of dump route info. > > Fix it by remove the rt->dst.error check. > > Bef

Re: [PATCHv4 net] ipv6: no need to check rt->dst.error when get route info

2017-07-27 Thread David Ahern
On 7/27/17 10:25 AM, Hangbin Liu wrote: > After commit 18c3a61c4264 ("net: ipv6: RTM_GETROUTE: return matched fib > result when requested"). When we get a prohibit ertry, we will return > -EACCES directly instead of dump route info. > > Fix it by remove the rt->dst.error check. > > Before fix: >

[PATCHv4 net] ipv6: no need to check rt->dst.error when get route info

2017-07-27 Thread Hangbin Liu
After commit 18c3a61c4264 ("net: ipv6: RTM_GETROUTE: return matched fib result when requested"). When we get a prohibit ertry, we will return -EACCES directly instead of dump route info. Fix it by remove the rt->dst.error check. Before fix: \# ip -6 route add prohibit 2003::/64 dev eth1 \# ip -6