RE: [PATCHv3 net-next 2/3] phy: marvell: Add ethtool statistics counters

2015-12-30 Thread Shaohui Xie
> -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Wednesday, December 30, 2015 11:13 PM > To: Shaohui Xie > Cc: David Miller; Florian Fainelli; netdev > Subject: Re: [PATCHv3 net-next 2/3] phy: marvell: Add ethtool statistics > counters > &

Re: [PATCHv3 net-next 2/3] phy: marvell: Add ethtool statistics counters

2015-12-30 Thread Andrew Lunn
On Wed, Dec 30, 2015 at 04:24:40AM +, Shaohui Xie wrote: > > Subject: [PATCHv3 net-next 2/3] phy: marvell: Add ethtool statistics > > counters > > +static int marvell_probe(struct phy_device *phydev) { > > + struct marvell_priv *priv; > > + > > + priv

RE: [PATCHv3 net-next 2/3] phy: marvell: Add ethtool statistics counters

2015-12-29 Thread Shaohui Xie
> Subject: [PATCHv3 net-next 2/3] phy: marvell: Add ethtool statistics counters > +static int marvell_probe(struct phy_device *phydev) { > + struct marvell_priv *priv; > + > + priv = devm_kzalloc(&phydev->dev, sizeof(*priv), GFP_KERNEL); > + if (!priv) >

[PATCHv3 net-next 2/3] phy: marvell: Add ethtool statistics counters

2015-12-29 Thread Andrew Lunn
The PHY counters receiver errors and errors while idle. Signed-off-by: Andrew Lunn --- drivers/net/phy/marvell.c | 135 ++ 1 file changed, 135 insertions(+) diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index 0240552b50f3..50b5eac