Re: [PATCHv3 net-next] gre: introduce native tunnel support for ERSPAN

2017-08-22 Thread William Tu
>> + struct metadata_dst *tun_dst = NULL; >> + const struct iphdr *iph; >> + struct erspanhdr *ershdr; >> + __be32 index; >> + __be32 session_id; >> + int len; > > Please order local variables from longest to shortest line, ie. reverse > christmas tree format. > thanks for t

Re: [PATCHv3 net-next] gre: introduce native tunnel support for ERSPAN

2017-08-21 Thread David Miller
From: William Tu Date: Fri, 18 Aug 2017 06:24:40 -0700 > +static int erspan_rcv(struct sk_buff *skb, struct tnl_ptk_info *tpi, > + int gre_hdr_len) > +{ > + struct net *net = dev_net(skb->dev); > + struct ip_tunnel_net *itn; > + struct ip_tunnel *tunnel; > + stru

[PATCHv3 net-next] gre: introduce native tunnel support for ERSPAN

2017-08-18 Thread William Tu
The patch adds ERSPAN type II tunnel support. The implementation is based on the draft at [1]. One of the purposes is for Linux box to be able to receive ERSPAN monitoring traffic sent from the Cisco switch, by creating a ERSPAN tunnel device. In addition, the patch also adds ERSPAN TX, so traffi