Re: [PATCHv3 3/3] CDC-NCM: record speed in status method

2021-03-19 Thread Grant Grundler
On Mon, Feb 22, 2021 at 10:14 AM Oliver Neukum wrote: > > Am Freitag, den 19.02.2021, 07:30 + schrieb Grant Grundler: > > On Thu, Feb 18, 2021 at 10:21 AM Oliver Neukum wrote: > > Hi, > > > Since this patch is missing the hunks that landed in the previous > > patch and needs a v4, I'll offer

Re: [PATCHv3 3/3] CDC-NCM: record speed in status method

2021-02-23 Thread Grant Grundler
.set_link_ksettings = usbnet_set_link_ksettings, + .get_link_ksettings = usbnet_get_link_ksettings_internal, + .set_link_ksettings = usbnet_set_link_ksettings_mii, }; This hunk should have been included in "[PATCHv3 3/3] CDC-NCM: record speed in status method&quo

Re: [PATCHv3 3/3] CDC-NCM: record speed in status method

2021-02-22 Thread Oliver Neukum
Am Freitag, den 19.02.2021, 07:30 + schrieb Grant Grundler: > On Thu, Feb 18, 2021 at 10:21 AM Oliver Neukum wrote: Hi, > Since this patch is missing the hunks that landed in the previous > patch and needs a v4, I'll offer my version of the commit message in That is bad. I will have to sear

Re: [PATCHv3 3/3] CDC-NCM: record speed in status method

2021-02-18 Thread Grant Grundler
Oliver, Can you include a 4th patch in the series to bring cdc_ether driver in line with the cdc_ncm behavior? I apologize for not including the patch inline - but it's late and I don't want to fight with gmail at this point. Patch is attached. Not tested. cheers, grant On Thu, Feb 18, 2021 at 1

Re: [PATCHv3 3/3] CDC-NCM: record speed in status method

2021-02-18 Thread Grant Grundler
On Thu, Feb 18, 2021 at 10:21 AM Oliver Neukum wrote: > > The driver has a status method for receiving speed updates. > The framework, however, had support functions only for devices > that reported their speed upon an explicit query over a MDIO > interface. > CDC_NCM however gets direct notificat

[PATCHv3 3/3] CDC-NCM: record speed in status method

2021-02-18 Thread Oliver Neukum
The driver has a status method for receiving speed updates. The framework, however, had support functions only for devices that reported their speed upon an explicit query over a MDIO interface. CDC_NCM however gets direct notifications from the device. As new support functions have become availabl