Re: [PATCHv3] 3c59x: fix missing dma_mapping_error check and bad ring refill logic

2018-01-22 Thread Neil Horman
On Mon, Jan 22, 2018 at 01:27:19AM -0500, tedheadster wrote: > On Wed, Jan 3, 2018 at 1:44 PM, David Miller wrote: > > From: Neil Horman > > Date: Wed, 3 Jan 2018 13:09:23 -0500 > > > >> A few spots in 3c59x missed calls to dma_mapping_error checks, casuing > >> WARN_ONS to trigger. Clean those

Re: [PATCHv3] 3c59x: fix missing dma_mapping_error check and bad ring refill logic

2018-01-21 Thread tedheadster
On Wed, Jan 3, 2018 at 1:44 PM, David Miller wrote: > From: Neil Horman > Date: Wed, 3 Jan 2018 13:09:23 -0500 > >> A few spots in 3c59x missed calls to dma_mapping_error checks, casuing >> WARN_ONS to trigger. Clean those up. While we're at it, refactor the >> refill code a bit so that if skb

Re: [PATCHv3] 3c59x: fix missing dma_mapping_error check and bad ring refill logic

2018-01-03 Thread David Miller
From: Neil Horman Date: Wed, 3 Jan 2018 13:09:23 -0500 > A few spots in 3c59x missed calls to dma_mapping_error checks, casuing > WARN_ONS to trigger. Clean those up. While we're at it, refactor the > refill code a bit so that if skb allocation or dma mapping fails, we > recycle the existing b

[PATCHv3] 3c59x: fix missing dma_mapping_error check and bad ring refill logic

2018-01-03 Thread Neil Horman
A few spots in 3c59x missed calls to dma_mapping_error checks, casuing WARN_ONS to trigger. Clean those up. While we're at it, refactor the refill code a bit so that if skb allocation or dma mapping fails, we recycle the existing buffer. This prevents holes in the rx ring, and makes for much sim