Re: [PATCHv2 next 0/3] blackhole device to invalidate dst

2019-06-28 Thread महेश बंडेवार
On Fri, Jun 28, 2019 at 11:22 AM Michael Chan wrote: > > On Thu, Jun 27, 2019 at 12:42 PM Mahesh Bandewar wrote: > > > However, Michael Chan had a setup > > where these fixes helped him mitigate the issue and not cause > > the crash. > > > > Our lab has finished testing these patches. The patch

Re: [PATCHv2 next 0/3] blackhole device to invalidate dst

2019-06-28 Thread Michael Chan
On Thu, Jun 27, 2019 at 12:42 PM Mahesh Bandewar wrote: > However, Michael Chan had a setup > where these fixes helped him mitigate the issue and not cause > the crash. > Our lab has finished testing these patches. The patches work in the sense that no oversize packets are now passed to the dr

[PATCHv2 next 0/3] blackhole device to invalidate dst

2019-06-27 Thread Mahesh Bandewar
When we invalidate dst or mark it "dead", we assign 'lo' to dst->dev. First of all this assignment is racy and more over, it has MTU implications. The standard dev MTU is 1500 while the Loopback MTU is 64k. TCP code when dereferencing the dst don't check if the dst is valid or not. TCP when derefe