Re: [PATCHv2 net-next 4/6] sctp: add the sctp_diag.c file

2016-04-11 Thread Marcelo Ricardo Leitner
On Fri, Apr 08, 2016 at 10:51:56PM -0700, Eric Dumazet wrote: > On Sat, 2016-04-09 at 12:53 +0800, Xin Long wrote: > > This one will implement all the interface of inet_diag, inet_diag_handler. > > which includes sctp_diag_dump, sctp_diag_dump_one and sctp_diag_get_info. > > > > +static int inet_

Re: [PATCHv2 net-next 4/6] sctp: add the sctp_diag.c file

2016-04-09 Thread Eric Dumazet
On Sat, 2016-04-09 at 23:40 +0800, Xin Long wrote: > you meant we can remove it here ? > yes, it seems similar with INET_DIAG_SKMEMINFO. > but I do not know if userpace may use INET_DIAG_MEMINFO now. > You are adding new features here. No problem of legacy code. Anyway, as I said you really ne

Re: [PATCHv2 net-next 4/6] sctp: add the sctp_diag.c file

2016-04-09 Thread Xin Long
On Sat, Apr 9, 2016 at 1:51 PM, Eric Dumazet wrote: > On Sat, 2016-04-09 at 12:53 +0800, Xin Long wrote: >> This one will implement all the interface of inet_diag, inet_diag_handler. >> which includes sctp_diag_dump, sctp_diag_dump_one and sctp_diag_get_info. > > >> +static int inet_assoc_diag_fil

Re: [PATCHv2 net-next 4/6] sctp: add the sctp_diag.c file

2016-04-08 Thread Eric Dumazet
On Sat, 2016-04-09 at 12:53 +0800, Xin Long wrote: > This one will implement all the interface of inet_diag, inet_diag_handler. > which includes sctp_diag_dump, sctp_diag_dump_one and sctp_diag_get_info. > +static int inet_assoc_diag_fill(struct sock *sk, > + struct sc

[PATCHv2 net-next 4/6] sctp: add the sctp_diag.c file

2016-04-08 Thread Xin Long
This one will implement all the interface of inet_diag, inet_diag_handler. which includes sctp_diag_dump, sctp_diag_dump_one and sctp_diag_get_info. It will work as a modules, and register inet_diag_handler when loading. Signed-off-by: Xin Long --- include/uapi/linux/inet_diag.h | 2 + net/sc