Re: [PATCHv2 net-next] ip_gre: remove CRC flag from dev features in gre_gso_segment

2021-01-13 Thread Alexander Duyck
On Wed, Jan 13, 2021 at 1:46 AM Xin Long wrote: > > On Wed, Jan 13, 2021 at 10:11 AM Alexander Duyck > wrote: > > > > On Mon, Jan 11, 2021 at 9:14 PM Xin Long wrote: > > > > > > On Tue, Jan 12, 2021 at 12:48 AM Alexander Duyck > > > wrote: > > > > > > > > On Mon, Jan 11, 2021 at 5:22 AM Xin Lon

Re: [PATCHv2 net-next] ip_gre: remove CRC flag from dev features in gre_gso_segment

2021-01-13 Thread Xin Long
On Wed, Jan 13, 2021 at 10:11 AM Alexander Duyck wrote: > > On Mon, Jan 11, 2021 at 9:14 PM Xin Long wrote: > > > > On Tue, Jan 12, 2021 at 12:48 AM Alexander Duyck > > wrote: > > > > > > On Mon, Jan 11, 2021 at 5:22 AM Xin Long wrote: > > > > > > > > This patch is to let it always do CRC check

Re: [PATCHv2 net-next] ip_gre: remove CRC flag from dev features in gre_gso_segment

2021-01-12 Thread Alexander Duyck
On Mon, Jan 11, 2021 at 9:14 PM Xin Long wrote: > > On Tue, Jan 12, 2021 at 12:48 AM Alexander Duyck > wrote: > > > > On Mon, Jan 11, 2021 at 5:22 AM Xin Long wrote: > > > > > > This patch is to let it always do CRC checksum in sctp_gso_segment() > > > by removing CRC flag from the dev features

Re: [PATCHv2 net-next] ip_gre: remove CRC flag from dev features in gre_gso_segment

2021-01-11 Thread Xin Long
On Tue, Jan 12, 2021 at 12:48 AM Alexander Duyck wrote: > > On Mon, Jan 11, 2021 at 5:22 AM Xin Long wrote: > > > > This patch is to let it always do CRC checksum in sctp_gso_segment() > > by removing CRC flag from the dev features in gre_gso_segment() for > > SCTP over GRE, just as it does in Co

Re: [PATCHv2 net-next] ip_gre: remove CRC flag from dev features in gre_gso_segment

2021-01-11 Thread Alexander Duyck
On Mon, Jan 11, 2021 at 5:22 AM Xin Long wrote: > > This patch is to let it always do CRC checksum in sctp_gso_segment() > by removing CRC flag from the dev features in gre_gso_segment() for > SCTP over GRE, just as it does in Commit 527beb8ef9c0 ("udp: support > sctp over udp in skb_udp_tunnel_se

[PATCHv2 net-next] ip_gre: remove CRC flag from dev features in gre_gso_segment

2021-01-11 Thread Xin Long
This patch is to let it always do CRC checksum in sctp_gso_segment() by removing CRC flag from the dev features in gre_gso_segment() for SCTP over GRE, just as it does in Commit 527beb8ef9c0 ("udp: support sctp over udp in skb_udp_tunnel_segment") for SCTP over UDP. It could set csum/csum_start in