Re: [PATCHv2 1/5] sh_eth: add generic wake-on-lan support via magic packet

2016-12-24 Thread Sergei Shtylyov
Hello! On 12/19/2016 08:11 PM, Geert Uytterhoeven wrote: One quirk needed for WoL is that the module clock needs to be prevented from being switched off by Runtime PM. To keep the clock alive the I tried to find the code in question and failed, getting muddled in the RPM maze. Could you po

Re: [PATCHv2 1/5] sh_eth: add generic wake-on-lan support via magic packet

2016-12-19 Thread Geert Uytterhoeven
Hi Niklas, On Mon, Dec 19, 2016 at 5:39 PM, Niklas Söderlund wrote: > On 2016-12-18 23:26:11 +0300, Sergei Shtylyov wrote: >> On 12/12/2016 07:09 PM, Niklas Söderlund wrote: >> > One quirk needed for WoL is that the module clock needs to be prevented >> > from being switched off by Runtime PM. To

Re: [PATCHv2 1/5] sh_eth: add generic wake-on-lan support via magic packet

2016-12-19 Thread Sergei Shtylyov
Hello! On 12/19/2016 07:41 PM, Niklas Söderlund wrote: [...] diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c index 05b0dc5..87640b9 100644 --- a/drivers/net/ethernet/renesas/sh_eth.c +++ b/drivers/net/ethernet/renesas/sh_eth.c [...] index d050f37..

Re: [PATCHv2 1/5] sh_eth: add generic wake-on-lan support via magic packet

2016-12-19 Thread Niklas Söderlund
Hi Sergei, On 2016-12-18 00:50:59 +0300, Sergei Shtylyov wrote: > Hello! > > On 12/12/2016 07:09 PM, Niklas Söderlund wrote: > >Not the complete review yet, just some superficial comments. > > > Add generic functionality to support Wake-on-Lan using MagicPacket which > >LAN. > > > are

Re: [PATCHv2 1/5] sh_eth: add generic wake-on-lan support via magic packet

2016-12-19 Thread Niklas Söderlund
Hi Sergei, Thanks for the spelling feedback, will include your suggestions in v3. Which I hope to post once rc1 is released and netdev opens, as you suggested to me previously. On 2016-12-18 23:26:11 +0300, Sergei Shtylyov wrote: > Hello. > > On 12/12/2016 07:09 PM, Niklas Söderlund wrote: > >

Re: [PATCHv2 1/5] sh_eth: add generic wake-on-lan support via magic packet

2016-12-18 Thread Sergei Shtylyov
Hello. On 12/12/2016 07:09 PM, Niklas Söderlund wrote: Add generic functionality to support Wake-on-Lan using MagicPacket which are supported by at least a few versions of sh_eth. Only add functionality for WoL, no specific sh_eth version are marked to support Versions. WoL yet. WoL is

Re: [PATCHv2 1/5] sh_eth: add generic wake-on-lan support via magic packet

2016-12-17 Thread Sergei Shtylyov
Hello! On 12/12/2016 07:09 PM, Niklas Söderlund wrote: Not the complete review yet, just some superficial comments. Add generic functionality to support Wake-on-Lan using MagicPacket which LAN. are supported by at least a few versions of sh_eth. Only add functionality for WoL, no spe

Re: [PATCHv2 1/5] sh_eth: add generic wake-on-lan support via magic packet

2016-12-13 Thread Niklas Söderlund
Hi Geert, Thanks for feedback and testing! On 2016-12-13 14:03:52 +0100, Geert Uytterhoeven wrote: > CC linux-pm I think you forgot to CC linux-pm :-) > > On Mon, Dec 12, 2016 at 5:09 PM, Niklas Söderlund > wrote: > > Add generic functionality to support Wake-on-Lan using MagicPacket which >

Re: [PATCHv2 1/5] sh_eth: add generic wake-on-lan support via magic packet

2016-12-13 Thread Geert Uytterhoeven
CC linux-pm On Mon, Dec 12, 2016 at 5:09 PM, Niklas Söderlund wrote: > Add generic functionality to support Wake-on-Lan using MagicPacket which > are supported by at least a few versions of sh_eth. Only add > functionality for WoL, no specific sh_eth version are marked to support > WoL yet. > > W

[PATCHv2 1/5] sh_eth: add generic wake-on-lan support via magic packet

2016-12-12 Thread Niklas Söderlund
Add generic functionality to support Wake-on-Lan using MagicPacket which are supported by at least a few versions of sh_eth. Only add functionality for WoL, no specific sh_eth version are marked to support WoL yet. WoL is enabled in the suspend callback by setting MagicPacket detection and disabli