Re: [PATCHv2] net: sh_eth: Add support for Renesas SuperH Ethernet

2008-02-08 Thread Yoshihiro Shimoda
Andrew Morton wrote: > On Thu, 07 Feb 2008 17:39:23 +0900 Yoshihiro Shimoda <[EMAIL PROTECTED]> > wrote: > >> Add support for Renesas SuperH Ethernet controller. >> This driver supported SH7710 and SH7712. >> > > Nice looking driver. > > Quick comments: Thank you very much for your comment. >

Re: [PATCHv2] net: sh_eth: Add support for Renesas SuperH Ethernet

2008-02-07 Thread Andrew Morton
On Thu, 07 Feb 2008 17:39:23 +0900 Yoshihiro Shimoda <[EMAIL PROTECTED]> wrote: > Add support for Renesas SuperH Ethernet controller. > This driver supported SH7710 and SH7712. > Nice looking driver. Quick comments: > ... > > +/* > + * Program the hardware MAC address from dev->dev_addr. > + *