Re: [PATCH v8 3/5] rxrpc: check return value of skb_to_sgvec always

2017-05-16 Thread Jason A. Donenfeld
On Mon, May 15, 2017 at 3:11 PM, David Howells wrote: > skb_to_sgvec() can return -EMSGSIZE in some circumstances. You shouldn't > return -ENOMEM here in such a case. Noted. I'll fix this up for the next round.

Re: [PATCH v8 3/5] rxrpc: check return value of skb_to_sgvec always

2017-05-15 Thread David Howells
Jason A. Donenfeld wrote: > + if (unlikely(skb_to_sgvec(skb, sg, offset, 8) < 0)) > + goto nomem; > ... > + if (unlikely(skb_to_sgvec(skb, sg, offset, len) < 0)) { > + if (sg != _sg) > + kfree(sg); > + goto nomem; skb_to_sgvec() can

[PATCH v8 3/5] rxrpc: check return value of skb_to_sgvec always

2017-05-11 Thread Jason A. Donenfeld
Signed-off-by: Jason A. Donenfeld Cc: David Howells --- net/rxrpc/rxkad.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/net/rxrpc/rxkad.c b/net/rxrpc/rxkad.c index 1bb9b2ccc267..ecab9334e3c1 100644 --- a/net/rxrpc/rxkad.c +++ b/net/rxrpc/rxkad.c @@ -227,7 +22