Re: [PATCH v8 0/5] Add the ability to do BPF directed error injection

2017-12-08 Thread Daniel Borkmann
On 12/08/2017 09:24 PM, Josef Bacik wrote: > On Fri, Dec 08, 2017 at 04:35:44PM +0100, Daniel Borkmann wrote: >> On 12/06/2017 05:12 PM, Josef Bacik wrote: >>> Jon noticed that I had a typo in my _ASM_KPROBE_ERROR_INJECT macro. I went >>> to >>> figure out why the compiler didn't catch it and it'

Re: [PATCH v8 0/5] Add the ability to do BPF directed error injection

2017-12-08 Thread Josef Bacik
On Fri, Dec 08, 2017 at 04:35:44PM +0100, Daniel Borkmann wrote: > On 12/06/2017 05:12 PM, Josef Bacik wrote: > > Jon noticed that I had a typo in my _ASM_KPROBE_ERROR_INJECT macro. I went > > to > > figure out why the compiler didn't catch it and it's because it was not used > > anywhere. I had

Re: [PATCH v8 0/5] Add the ability to do BPF directed error injection

2017-12-08 Thread Daniel Borkmann
On 12/06/2017 05:12 PM, Josef Bacik wrote: > Jon noticed that I had a typo in my _ASM_KPROBE_ERROR_INJECT macro. I went to > figure out why the compiler didn't catch it and it's because it was not used > anywhere. I had copied it from the trace blacklist code without understanding > where it was

[PATCH v8 0/5] Add the ability to do BPF directed error injection

2017-12-06 Thread Josef Bacik
Jon noticed that I had a typo in my _ASM_KPROBE_ERROR_INJECT macro. I went to figure out why the compiler didn't catch it and it's because it was not used anywhere. I had copied it from the trace blacklist code without understanding where it was used as cscope didn't find the original macro I was