Re: [PATCH v7 00/11] Stop monitoring disabled devices

2020-07-03 Thread Daniel Lezcano
On 03/07/2020 12:45, Andrzej Pietrasiewicz wrote: > Hi, > > W dniu 03.07.2020 o 08:38, Daniel Lezcano pisze: >> On 03/07/2020 03:49, Zhang Rui wrote: >>> On Thu, 2020-07-02 at 19:49 +0200, Daniel Lezcano wrote: >> >> [ ... ] >> > So the reason is that ->get_temp() is called while the mutex is

Re: [PATCH v7 00/11] Stop monitoring disabled devices

2020-07-03 Thread Andrzej Pietrasiewicz
Hi, W dniu 03.07.2020 o 08:38, Daniel Lezcano pisze: On 03/07/2020 03:49, Zhang Rui wrote: On Thu, 2020-07-02 at 19:49 +0200, Daniel Lezcano wrote: [ ... ] So the reason is that ->get_temp() is called while the mutex is held and thermal_zone_device_is_enabled() wants to take the same mutex.

Re: [PATCH v7 00/11] Stop monitoring disabled devices

2020-07-02 Thread Daniel Lezcano
On 03/07/2020 03:49, Zhang Rui wrote: > On Thu, 2020-07-02 at 19:49 +0200, Daniel Lezcano wrote: [ ... ] >>> So the reason is that ->get_temp() is called while the mutex is >>> held and >>> thermal_zone_device_is_enabled() wants to take the same mutex. >> >> Yes, that's correct. >> >>> Is adding

Re: [PATCH v7 00/11] Stop monitoring disabled devices

2020-07-02 Thread Zhang Rui
On Thu, 2020-07-02 at 19:49 +0200, Daniel Lezcano wrote: > On 02/07/2020 19:19, Andrzej Pietrasiewicz wrote: > > Hi, > > > > W dniu 02.07.2020 o 19:01, Daniel Lezcano pisze: > > > On 02/07/2020 15:53, Andrzej Pietrasiewicz wrote: > > > > Hi Daniel, > > > > > > > > > > > > > > > > > > > > > > >

Re: [PATCH v7 00/11] Stop monitoring disabled devices

2020-07-02 Thread Daniel Lezcano
On 02/07/2020 19:49, Daniel Lezcano wrote: [ ... ] >> Thanks! >> >> That confirms your suspicions. >> >> So the reason is that ->get_temp() is called while the mutex is held and >> thermal_zone_device_is_enabled() wants to take the same mutex. > > Yes, that's correct. > >> Is adding a comment t

Re: [PATCH v7 00/11] Stop monitoring disabled devices

2020-07-02 Thread Daniel Lezcano
On 02/07/2020 19:19, Andrzej Pietrasiewicz wrote: > Hi, > > W dniu 02.07.2020 o 19:01, Daniel Lezcano pisze: >> On 02/07/2020 15:53, Andrzej Pietrasiewicz wrote: >>> Hi Daniel, >>> >>> >>> I did reproduce: v5.8-rc3 + series => imx6 hang at boot time v5

Re: [PATCH v7 00/11] Stop monitoring disabled devices

2020-07-02 Thread Andrzej Pietrasiewicz
Hi, W dniu 02.07.2020 o 19:01, Daniel Lezcano pisze: On 02/07/2020 15:53, Andrzej Pietrasiewicz wrote: Hi Daniel, I did reproduce: v5.8-rc3 + series => imx6 hang at boot time v5.8-rc3 => imx6 boots correctly So finally I succeeded to reproduce it on my imx7 locally. The sensor was faili

Re: [PATCH v7 00/11] Stop monitoring disabled devices

2020-07-02 Thread Daniel Lezcano
On 02/07/2020 15:53, Andrzej Pietrasiewicz wrote: > Hi Daniel, > > > >> >> I did reproduce: >> >> v5.8-rc3 + series => imx6 hang at boot time >> v5.8-rc3 => imx6 boots correctly >> >> So finally I succeeded to reproduce it on my imx7 locally. The sensor >> was failing to init

Re: [PATCH v7 00/11] Stop monitoring disabled devices

2020-07-02 Thread Daniel Lezcano
On 02/07/2020 15:53, Andrzej Pietrasiewicz wrote: > Hi Daniel, > > > >> >> I did reproduce: >> >> v5.8-rc3 + series => imx6 hang at boot time >> v5.8-rc3 => imx6 boots correctly >> >> So finally I succeeded to reproduce it on my imx7 locally. The sensor >> was failing to init

Re: [PATCH v7 00/11] Stop monitoring disabled devices

2020-07-02 Thread Andrzej Pietrasiewicz
Hi Daniel, I did reproduce: v5.8-rc3 + series => imx6 hang at boot time v5.8-rc3 => imx6 boots correctly So finally I succeeded to reproduce it on my imx7 locally. The sensor was failing to initialize for another reason related to the legacy cooling device, this is why it is not appearing

Re: [PATCH v7 00/11] Stop monitoring disabled devices

2020-07-02 Thread Daniel Lezcano
On 01/07/2020 12:23, Andrzej Pietrasiewicz wrote: > Hi, > > W dniu 30.06.2020 o 20:33, Daniel Lezcano pisze: >> On 30/06/2020 18:56, Andrzej Pietrasiewicz wrote: >>> Hi, >>> >>> W dniu 30.06.2020 o 17:53, Daniel Lezcano pisze: On 30/06/2020 17:29, Andrzej Pietrasiewicz wrote: > Hi Daniel,

Re: [PATCH v7 00/11] Stop monitoring disabled devices

2020-07-01 Thread Daniel Lezcano
On 01/07/2020 12:23, Andrzej Pietrasiewicz wrote: > Hi, > [ ... ] I did reproduce: v5.8-rc3 + series => imx6 hang at boot time v5.8-rc3 => imx6 boots correctly > > What did you reproduce? Timeout logging in to the test system or a > "real" failure of a test? Timeo

Re: [PATCH v7 00/11] Stop monitoring disabled devices

2020-07-01 Thread Andrzej Pietrasiewicz
Hi, W dniu 30.06.2020 o 20:33, Daniel Lezcano pisze: On 30/06/2020 18:56, Andrzej Pietrasiewicz wrote: Hi, W dniu 30.06.2020 o 17:53, Daniel Lezcano pisze: On 30/06/2020 17:29, Andrzej Pietrasiewicz wrote: Hi Daniel, W dniu 30.06.2020 o 16:53, Daniel Lezcano pisze: On 30/06/2020 15:43, And

Re: [PATCH v7 00/11] Stop monitoring disabled devices

2020-06-30 Thread Daniel Lezcano
On 30/06/2020 18:56, Andrzej Pietrasiewicz wrote: > Hi, > > W dniu 30.06.2020 o 17:53, Daniel Lezcano pisze: >> On 30/06/2020 17:29, Andrzej Pietrasiewicz wrote: >>> Hi Daniel, >>> >>> W dniu 30.06.2020 o 16:53, Daniel Lezcano pisze: On 30/06/2020 15:43, Andrzej Pietrasiewicz wrote: > Hi

Re: [PATCH v7 00/11] Stop monitoring disabled devices

2020-06-30 Thread Andrzej Pietrasiewicz
Hi, W dniu 30.06.2020 o 17:53, Daniel Lezcano pisze: On 30/06/2020 17:29, Andrzej Pietrasiewicz wrote: Hi Daniel, W dniu 30.06.2020 o 16:53, Daniel Lezcano pisze: On 30/06/2020 15:43, Andrzej Pietrasiewicz wrote: Hi Daniel, I am reading the logs and can't find anything specific to thermal.

Re: [PATCH v7 00/11] Stop monitoring disabled devices

2020-06-30 Thread Daniel Lezcano
On 30/06/2020 17:29, Andrzej Pietrasiewicz wrote: > Hi Daniel, > > W dniu 30.06.2020 o 16:53, Daniel Lezcano pisze: >> On 30/06/2020 15:43, Andrzej Pietrasiewicz wrote: >>> Hi Daniel, >>> >>> I am reading the logs and can't find anything specific to thermal. >>> >>> What I can see is >>> >>> "rand

Re: [PATCH v7 00/11] Stop monitoring disabled devices

2020-06-30 Thread Andrzej Pietrasiewicz
Hi Daniel, W dniu 30.06.2020 o 16:53, Daniel Lezcano pisze: On 30/06/2020 15:43, Andrzej Pietrasiewicz wrote: Hi Daniel, I am reading the logs and can't find anything specific to thermal. What I can see is "random: crng init done" with large times (~200s) and then e.g. 'auto-login-action t

Re: [PATCH v7 00/11] Stop monitoring disabled devices

2020-06-30 Thread Daniel Lezcano
On 30/06/2020 15:43, Andrzej Pietrasiewicz wrote: > Hi Daniel, > > I am reading the logs and can't find anything specific to thermal. > > What I can see is > > "random: crng init done" > > with large times (~200s) and then e.g. > > 'auto-login-action timed out after 283 seconds' > > I'm looki

Re: [PATCH v7 00/11] Stop monitoring disabled devices

2020-06-30 Thread Andrzej Pietrasiewicz
Hi Daniel, I am reading the logs and can't find anything specific to thermal. What I can see is "random: crng init done" with large times (~200s) and then e.g. 'auto-login-action timed out after 283 seconds' I'm looking at e.g. https://storage.kernelci.org/thermal/testing/v5.8-rc3-11-gf5e50

Re: [PATCH v7 00/11] Stop monitoring disabled devices

2020-06-30 Thread Daniel Lezcano
Hi Andrzej, I've tested your series with kernelci and there are 3 regressions for the imx6. https://kernelci.org/test/job/thermal/branch/testing/kernel/v5.8-rc3-11-gf5e50bf4d3ef/plan/baseline/ On 29/06/2020 14:29, Andrzej Pietrasiewicz wrote: > A respin of v6 with these changes: > > v6..v7:

[PATCH v7 00/11] Stop monitoring disabled devices

2020-06-29 Thread Andrzej Pietrasiewicz
A respin of v6 with these changes: v6..v7: - removed duplicate S-o-b line from patch 6/11 v5..v6: - staticized thermal_zone_device_set_mode() (kbuild test robot) v4..v5: - EXPORT_SYMBOL -> EXPORT_SYMBOL_GPL (Daniel) - dropped unnecessary thermal_zone_device_enable() in int3400_thermal.c and in