Re: [PATCH v6 1/4] can: m_can: Create a m_can platform framework

2019-03-04 Thread Joe Perches
On Mon, 2019-03-04 at 13:12 -0600, Dan Murphy wrote: > On 3/4/19 12:13 PM, Wolfgang Grandegger wrote: > > Am 04.03.19 um 18:22 schrieb Dan Murphy: > > > > > + int pm_clock_support; > > > > > > > > A "bool" would be more appropriate, I think. > > > > > > I was abiding by this checkpatch warnin

Re: [PATCH v6 1/4] can: m_can: Create a m_can platform framework

2019-03-04 Thread Dan Murphy
On 3/4/19 10:56 AM, Wolfgang Grandegger wrote: > Hello Dan, > > the series already looks quite good. I still realized a few (minor) > issues while browsing the patch/code... > > Am 01.03.19 um 19:50 schrieb Dan Murphy: >> Create a m_can platform framework that peripherial >> devices can register

Re: [PATCH v6 1/4] can: m_can: Create a m_can platform framework

2019-03-04 Thread Dan Murphy
Wolfgang On 3/4/19 12:13 PM, Wolfgang Grandegger wrote: > > > Am 04.03.19 um 18:22 schrieb Dan Murphy: >> Wolfgang >> >> On 3/4/19 10:56 AM, Wolfgang Grandegger wrote: >>> Hello Dan, >>> >>> the series already looks quite good. I still realized a few (minor) >>> issues while browsing the patch/c

Re: [PATCH v6 1/4] can: m_can: Create a m_can platform framework

2019-03-04 Thread Wolfgang Grandegger
Am 04.03.19 um 18:22 schrieb Dan Murphy: > Wolfgang > > On 3/4/19 10:56 AM, Wolfgang Grandegger wrote: >> Hello Dan, >> >> the series already looks quite good. I still realized a few (minor) >> issues while browsing the patch/code... >> > > Thanks for the review. It is getting there. > >> Am

Re: [PATCH v6 1/4] can: m_can: Create a m_can platform framework

2019-03-04 Thread Dan Murphy
Wolfgang On 3/4/19 10:56 AM, Wolfgang Grandegger wrote: > Hello Dan, > > the series already looks quite good. I still realized a few (minor) > issues while browsing the patch/code... > Thanks for the review. It is getting there. > Am 01.03.19 um 19:50 schrieb Dan Murphy: >> Create a m_can pla

Re: [PATCH v6 1/4] can: m_can: Create a m_can platform framework

2019-03-04 Thread Wolfgang Grandegger
Hello Dan, the series already looks quite good. I still realized a few (minor) issues while browsing the patch/code... Am 01.03.19 um 19:50 schrieb Dan Murphy: > Create a m_can platform framework that peripherial > devices can register to and use common code and register sets. > The peripherial d

[PATCH v6 1/4] can: m_can: Create a m_can platform framework

2019-03-01 Thread Dan Murphy
Create a m_can platform framework that peripherial devices can register to and use common code and register sets. The peripherial devices may provide read/write and configuration support of the IP. Signed-off-by: Dan Murphy --- v6 - Squashed platform patch to this patch for bissectablity, fixed