Re: [PATCH v5 net-next 11/16] net: propagate errors from dev_get_stats

2021-01-11 Thread Vladimir Oltean
Hi Dan, On Mon, Jan 11, 2021 at 01:55:16PM +0300, Dan Carpenter wrote: > Hi Vladimir, > > New smatch warnings: > net/core/rtnetlink.c:1821 rtnl_fill_ifinfo() warn: missing error code 'err' > > vim +/err +1821 net/core/rtnetlink.c > > static int rtnl_fill_ifinfo(struct sk_buff *skb, >

Re: [PATCH v5 net-next 11/16] net: propagate errors from dev_get_stats

2021-01-11 Thread Dan Carpenter
Hi Vladimir, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Vladimir-Oltean/Make-ndo_get_stats64-sleepable/20210109-003617 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git

Re: [PATCH v5 net-next 11/16] net: propagate errors from dev_get_stats

2021-01-08 Thread Vladimir Oltean
On Fri, Jan 08, 2021 at 06:31:54PM +0200, Vladimir Oltean wrote: > From: Vladimir Oltean > > dev_get_stats can now return error codes. Take the remaining call sites > where those errors can be propagated, which are all trivial, and convert > them to look at that error code and stop processing. >

[PATCH v5 net-next 11/16] net: propagate errors from dev_get_stats

2021-01-08 Thread Vladimir Oltean
From: Vladimir Oltean dev_get_stats can now return error codes. Take the remaining call sites where those errors can be propagated, which are all trivial, and convert them to look at that error code and stop processing. The effects of simulating a kernel error (returning -ENOMEM) upon existing p