Re: [PATCH v5 net-next 01/18] ionic: Add basic framework for IONIC Network device driver

2019-08-27 Thread Shannon Nelson
On 8/26/19 9:06 PM, Jakub Kicinski wrote: On Mon, 26 Aug 2019 14:33:22 -0700, Shannon Nelson wrote: +struct ionic { + struct pci_dev *pdev; + struct device *dev; + struct devlink *dl; No need for the dl pointer here. priv_to_devlink can be used to obtain the devlink pointer ba

Re: [PATCH v5 net-next 01/18] ionic: Add basic framework for IONIC Network device driver

2019-08-26 Thread Jakub Kicinski
On Mon, 26 Aug 2019 14:33:22 -0700, Shannon Nelson wrote: > +struct ionic { > + struct pci_dev *pdev; > + struct device *dev; > + struct devlink *dl; No need for the dl pointer here. priv_to_devlink can be used to obtain the devlink pointer based on priv structure address. > +};

[PATCH v5 net-next 01/18] ionic: Add basic framework for IONIC Network device driver

2019-08-26 Thread Shannon Nelson
This patch adds a basic driver framework for the Pensando IONIC network device. There is no functionality right now other than the ability to load and unload. Signed-off-by: Shannon Nelson --- .../networking/device_drivers/index.rst | 1 + .../device_drivers/pensando/ionic.rst |