Re: [PATCH v5 net-next] net: ipv4: Consider failed nexthops in multipath routes

2016-04-06 Thread David Miller
From: David Ahern Date: Sun, 3 Apr 2016 17:09:07 -0700 > + rcu_read_lock_bh(); > + > + n = __neigh_lookup_noref(&arp_tbl, &nh->nh_gw, nh->nh_dev); > + if (n) > + state = n->nud_state; > + > + rcu_read_unlock_bh(); Please use __

Re: [PATCH v5 net-next] net: ipv4: Consider failed nexthops in multipath routes

2016-04-04 Thread David Ahern
On 4/4/16 12:29 AM, Julian Anastasov wrote: Reviewed-by: Julian Anastasov With one comment: the fallback strategy is simplified, we do not fallback to all possible reachable nexthops. Right. I will send a second patch that examines other nexthops (hash <= nh_upper_bound).

Re: [PATCH v5 net-next] net: ipv4: Consider failed nexthops in multipath routes

2016-04-03 Thread Julian Anastasov
Hello, On Sun, 3 Apr 2016, David Ahern wrote: > Multipath route lookups should consider knowledge about next hops and not > select a hop that is known to be failed. > > Example: > > [h2] [h3] 15.0.0.5 > |

[PATCH v5 net-next] net: ipv4: Consider failed nexthops in multipath routes

2016-04-03 Thread David Ahern
Multipath route lookups should consider knowledge about next hops and not select a hop that is known to be failed. Example: [h2] [h3] 15.0.0.5 | | 3| 3|