Re: [PATCH v5 02/13] net: ethernet: aquantia: Common functions and definitions

2017-01-13 Thread David Miller
From: Alexander Loktionov Date: Thu, 12 Jan 2017 21:02:18 -0800 > +#define AQ_OBJ_HEADER spinlock_t lock; atomic_t flags; atomic_t busy_count > + > +struct aq_obj_s { > + AQ_OBJ_HEADER; > +}; Please don't hide multiple declarations and types inside of a macro, that makes the code harder to u

[PATCH v5 02/13] net: ethernet: aquantia: Common functions and definitions

2017-01-12 Thread Alexander Loktionov
From: David VomLehn Add files containing the functions and definitions used in common in different functional areas. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel Belous Signed-off-by: Dmitry Bezrukov Signed-off-by: David M. VomLehn --- drivers/ne