Re: [PATCH v4 net-next 3/3] tcp: Handle eor bit when fragmenting a skb

2016-04-25 Thread Soheil Hassas Yeganeh
On Mon, Apr 25, 2016 at 5:44 PM, Martin KaFai Lau wrote: > When fragmenting a skb, the next_skb should carry > the eor from prev_skb. The eor of prev_skb should > also be reset. > > Packetdrill script for testing: > ~~ > +0 `sysctl -q -w net.ipv4.tcp_min_tso_segs=10` > +0 `sysctl -q -w net.ip

Re: [PATCH v4 net-next 3/3] tcp: Handle eor bit when fragmenting a skb

2016-04-25 Thread Eric Dumazet
On Mon, 2016-04-25 at 14:44 -0700, Martin KaFai Lau wrote: > When fragmenting a skb, the next_skb should carry > the eor from prev_skb. The eor of prev_skb should > also be reset. Acked-by: Eric Dumazet

[PATCH v4 net-next 3/3] tcp: Handle eor bit when fragmenting a skb

2016-04-25 Thread Martin KaFai Lau
When fragmenting a skb, the next_skb should carry the eor from prev_skb. The eor of prev_skb should also be reset. Packetdrill script for testing: ~~ +0 `sysctl -q -w net.ipv4.tcp_min_tso_segs=10` +0 `sysctl -q -w net.ipv4.tcp_no_metrics_save=1` +0 socket(..., SOCK_STREAM, IPPROTO_TCP) = 3 +0