Re: [PATCH v4 net-next 02/19] ionic: Add hardware init and device commands

2019-07-24 Thread Shannon Nelson
On 7/23/19 5:25 PM, Shannon Nelson wrote: On 7/23/19 4:47 PM, Saeed Mahameed wrote: On Mon, 2019-07-22 at 14:40 -0700, Shannon Nelson wrote: + +    /* Wait for dev cmd to complete, retrying if we get EAGAIN, + * but don't wait any longer than max_seconds. + */ +    max_wait = jiffies

Re: [PATCH v4 net-next 02/19] ionic: Add hardware init and device commands

2019-07-24 Thread David Miller
From: Shannon Nelson Date: Wed, 24 Jul 2019 10:49:09 -0700 > On 7/23/19 4:05 PM, David Miller wrote: >> From: Shannon Nelson >> Date: Tue, 23 Jul 2019 15:50:22 -0700 >> >>> On 7/23/19 2:18 PM, David Miller wrote: From: Shannon Nelson Date: Mon, 22 Jul 2019 14:40:06 -0700 > +v

Re: [PATCH v4 net-next 02/19] ionic: Add hardware init and device commands

2019-07-24 Thread Shannon Nelson
On 7/23/19 4:05 PM, David Miller wrote: From: Shannon Nelson Date: Tue, 23 Jul 2019 15:50:22 -0700 On 7/23/19 2:18 PM, David Miller wrote: From: Shannon Nelson Date: Mon, 22 Jul 2019 14:40:06 -0700 +void ionic_init_devinfo(struct ionic_dev *idev) +{ + idev->dev_info.asic_type = ioread8(&id

Re: [PATCH v4 net-next 02/19] ionic: Add hardware init and device commands

2019-07-23 Thread Shannon Nelson
On 7/23/19 4:47 PM, Saeed Mahameed wrote: On Mon, 2019-07-22 at 14:40 -0700, Shannon Nelson wrote: The ionic device has a small set of PCI registers, including a device control and data space, and a large set of message commands. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensand

Re: [PATCH v4 net-next 02/19] ionic: Add hardware init and device commands

2019-07-23 Thread Saeed Mahameed
On Mon, 2019-07-22 at 14:40 -0700, Shannon Nelson wrote: > The ionic device has a small set of PCI registers, including a > device control and data space, and a large set of message > commands. > > Signed-off-by: Shannon Nelson > --- > drivers/net/ethernet/pensando/ionic/Makefile |2 +- > d

Re: [PATCH v4 net-next 02/19] ionic: Add hardware init and device commands

2019-07-23 Thread Shannon Nelson
On 7/23/19 4:05 PM, David Miller wrote: From: Shannon Nelson Date: Tue, 23 Jul 2019 15:50:22 -0700 On 7/23/19 2:18 PM, David Miller wrote: From: Shannon Nelson Date: Mon, 22 Jul 2019 14:40:06 -0700 +void ionic_init_devinfo(struct ionic_dev *idev) +{ + idev->dev_info.asic_type = ioread8(&id

Re: [PATCH v4 net-next 02/19] ionic: Add hardware init and device commands

2019-07-23 Thread David Miller
From: Shannon Nelson Date: Tue, 23 Jul 2019 15:50:22 -0700 > On 7/23/19 2:18 PM, David Miller wrote: >> From: Shannon Nelson >> Date: Mon, 22 Jul 2019 14:40:06 -0700 >> >>> +void ionic_init_devinfo(struct ionic_dev *idev) >>> +{ >>> + idev->dev_info.asic_type = ioread8(&idev->dev_info_regs->asic

Re: [PATCH v4 net-next 02/19] ionic: Add hardware init and device commands

2019-07-23 Thread Shannon Nelson
On 7/23/19 2:18 PM, David Miller wrote: From: Shannon Nelson Date: Mon, 22 Jul 2019 14:40:06 -0700 +void ionic_init_devinfo(struct ionic_dev *idev) +{ + idev->dev_info.asic_type = ioread8(&idev->dev_info_regs->asic_type); + idev->dev_info.asic_rev = ioread8(&idev->dev_info_regs->as

Re: [PATCH v4 net-next 02/19] ionic: Add hardware init and device commands

2019-07-23 Thread David Miller
From: Shannon Nelson Date: Mon, 22 Jul 2019 14:40:06 -0700 > +void ionic_init_devinfo(struct ionic_dev *idev) > +{ > + idev->dev_info.asic_type = ioread8(&idev->dev_info_regs->asic_type); > + idev->dev_info.asic_rev = ioread8(&idev->dev_info_regs->asic_rev); > + > + memcpy_fromio(idev

[PATCH v4 net-next 02/19] ionic: Add hardware init and device commands

2019-07-22 Thread Shannon Nelson
The ionic device has a small set of PCI registers, including a device control and data space, and a large set of message commands. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/Makefile |2 +- drivers/net/ethernet/pensando/ionic/ionic.h | 20 + .../net/ethernet/p