Re: [PATCH v4 net-next 0/3] tcp: Make use of MSG_EOR in tcp_sendmsg

2016-04-28 Thread David Miller
From: Martin KaFai Lau Date: Mon, 25 Apr 2016 14:44:47 -0700 ... > One potential use case is to use MSG_EOR with > SOF_TIMESTAMPING_TX_ACK to get a more accurate > TCP ack timestamping on application protocol with > multiple outgoing response messages (e.g. HTTP2). > > One of our use case is at

Re: [PATCH v4 net-next 0/3] tcp: Make use of MSG_EOR in tcp_sendmsg

2016-04-25 Thread Soheil Hassas Yeganeh
On Mon, Apr 25, 2016 at 5:44 PM, Martin KaFai Lau wrote: > v4: > ~ Do not set eor bit in do_tcp_sendpages() since there is > no way to pass MSG_EOR from the userland now. > ~ Avoid rmw by testing MSG_EOR first in tcp_sendmsg(). > ~ Move TCP_SKB_CB(skb)->eor test to a new helper > tcp_skb_can_c

[PATCH v4 net-next 0/3] tcp: Make use of MSG_EOR in tcp_sendmsg

2016-04-25 Thread Martin KaFai Lau
v4: ~ Do not set eor bit in do_tcp_sendpages() since there is no way to pass MSG_EOR from the userland now. ~ Avoid rmw by testing MSG_EOR first in tcp_sendmsg(). ~ Move TCP_SKB_CB(skb)->eor test to a new helper tcp_skb_can_collapse_to() (suggested by Soheil). ~ Add some packetdrill tests. v3: