Re: [PATCH v4 bpf-next 06/14] bpf: Use BTF_ID to resolve bpf_ctx_convert struct

2020-06-28 Thread Jiri Olsa
On Fri, Jun 26, 2020 at 02:44:39PM -0700, Yonghong Song wrote: > > > On 6/25/20 3:12 PM, Jiri Olsa wrote: > > This way the ID is resolved during compile time, > > and we can remove the runtime name search. > > > > Signed-off-by: Jiri Olsa > > --- > > kernel/bpf/btf.c | 12 > > 1

Re: [PATCH v4 bpf-next 06/14] bpf: Use BTF_ID to resolve bpf_ctx_convert struct

2020-06-26 Thread Yonghong Song
On 6/25/20 3:12 PM, Jiri Olsa wrote: This way the ID is resolved during compile time, and we can remove the runtime name search. Signed-off-by: Jiri Olsa --- kernel/bpf/btf.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf

Re: [PATCH v4 bpf-next 06/14] bpf: Use BTF_ID to resolve bpf_ctx_convert struct

2020-06-26 Thread Andrii Nakryiko
On Thu, Jun 25, 2020 at 4:47 PM Jiri Olsa wrote: > > This way the ID is resolved during compile time, > and we can remove the runtime name search. > > Signed-off-by: Jiri Olsa > --- This is a good improvement, but I was thinking about actually simplifying btf_get_prog_ctx_type() logic itself (it

[PATCH v4 bpf-next 06/14] bpf: Use BTF_ID to resolve bpf_ctx_convert struct

2020-06-25 Thread Jiri Olsa
This way the ID is resolved during compile time, and we can remove the runtime name search. Signed-off-by: Jiri Olsa --- kernel/bpf/btf.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c index 4da6b0770ff9..701a2cb5dfb2 100644 -