Re: [PATCH v4 4/7] can: replace can_dlc as variable/element for payload length

2020-11-09 Thread Oliver Hartkopp
Hi Vincent, On 09.11.20 13:59, Vincent MAILHOL wrote: On Mon. 9 Nov 2020 at 19:26, Oliver Hartkopp wrote: diff --git a/include/linux/can/dev.h b/include/linux/can/dev.h index b2e8df8e4cb0..72671184a7a2 100644 --- a/include/linux/can/dev.h +++ b/include/linux/can/dev.h @@ -183,12 +183,12 @@ stat

Re: [PATCH v4 4/7] can: replace can_dlc as variable/element for payload length

2020-11-09 Thread Vincent MAILHOL
On Mon. 9 Nov 2020 at 19:26, Oliver Hartkopp wrote: > diff --git a/include/linux/can/dev.h b/include/linux/can/dev.h > index b2e8df8e4cb0..72671184a7a2 100644 > --- a/include/linux/can/dev.h > +++ b/include/linux/can/dev.h > @@ -183,12 +183,12 @@ static inline void can_set_static_ctrlmode(struct >

[PATCH v4 4/7] can: replace can_dlc as variable/element for payload length

2020-11-09 Thread Oliver Hartkopp
The naming of can_dlc as element of struct can_frame and also as variable name is misleading as it claims to be a 'data length CODE' but in reality it always was a plain data length. With the indroduction of a new 'len' element in struct can_frame we can now remove can_dlc as name and make clear w