Re: [PATCH v4 1/4] ethtool: improve compat ioctl handling

2020-11-24 Thread Arnd Bergmann
On Tue, Nov 24, 2020 at 5:19 PM David Laight wrote: > > From: Arnd Bergmann > > Sent: 24 November 2020 15:18 > > > > The ethtool compat ioctl handling is hidden away in net/socket.c, > > which introduces a couple of minor oddities: > > > ... > > + > > +static int ethtool_rxnfc_copy_from_compat(str

RE: [PATCH v4 1/4] ethtool: improve compat ioctl handling

2020-11-24 Thread David Laight
From: Arnd Bergmann > Sent: 24 November 2020 15:18 > > The ethtool compat ioctl handling is hidden away in net/socket.c, > which introduces a couple of minor oddities: > ... > + > +static int ethtool_rxnfc_copy_from_compat(struct ethtool_rxnfc *rxnfc, > + con

[PATCH v4 1/4] ethtool: improve compat ioctl handling

2020-11-24 Thread Arnd Bergmann
From: Arnd Bergmann The ethtool compat ioctl handling is hidden away in net/socket.c, which introduces a couple of minor oddities: - The implementation may end up diverging, as seen in the RXNFC extension in commit 84a1d9c48200 ("net: ethtool: extend RXNFC API to support RSS spreading of fil