Re: [PATCH v4] qe: miscellaneous code improvements and fixes to the QE library

2007-10-03 Thread Kumar Gala
On Oct 3, 2007, at 1:00 PM, Timur Tabi wrote: Stephen Hemminger wrote: Separate the changes into individual patches to allow for better comment/review and bisection in case of regression. That would be too difficult. Some of the changes are single lines, and this patch has already been

Re: [PATCH v4] qe: miscellaneous code improvements and fixes to the QE library

2007-10-03 Thread Timur Tabi
Stephen Hemminger wrote: Separate the changes into individual patches to allow for better comment/review and bisection in case of regression. That would be too difficult. Some of the changes are single lines, and this patch has already been approved -- I just cross-posted to netdev because I

Re: [PATCH v4] qe: miscellaneous code improvements and fixes to the QE library

2007-10-03 Thread Stephen Hemminger
On Wed, 3 Oct 2007 11:34:59 -0500 Timur Tabi <[EMAIL PROTECTED]> wrote: > This patch makes numerous miscellaneous code improvements to the QE library. > > 1. Remove struct ucc_common and merge ucc_init_guemr() into ucc_set_type() >(every caller of ucc_init_guemr() also calls ucc_set_type()).

[PATCH v4] qe: miscellaneous code improvements and fixes to the QE library

2007-10-03 Thread Timur Tabi
This patch makes numerous miscellaneous code improvements to the QE library. 1. Remove struct ucc_common and merge ucc_init_guemr() into ucc_set_type() (every caller of ucc_init_guemr() also calls ucc_set_type()). Modify all callers of ucc_set_type() accordingly. 2. Remove the unused enum