Re: [PATCH v3 net-next 7/8] geneve: Consolidate Geneve functionality in single module.

2015-08-25 Thread Pravin Shelar
On Tue, Aug 25, 2015 at 2:35 PM, Jesse Gross wrote: > On Tue, Aug 25, 2015 at 1:54 PM, Pravin Shelar wrote: >> On Tue, Aug 25, 2015 at 12:03 PM, Jesse Gross wrote: >>> On Mon, Aug 24, 2015 at 10:43 AM, Pravin B Shelar >>> wrote: diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c >>>

Re: [PATCH v3 net-next 7/8] geneve: Consolidate Geneve functionality in single module.

2015-08-25 Thread Jesse Gross
On Tue, Aug 25, 2015 at 1:54 PM, Pravin Shelar wrote: > On Tue, Aug 25, 2015 at 12:03 PM, Jesse Gross wrote: >> On Mon, Aug 24, 2015 at 10:43 AM, Pravin B Shelar wrote: >>> diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c >>> index c05bc13..8eb875d 100644 >>> --- a/drivers/net/geneve.c >

Re: [PATCH v3 net-next 7/8] geneve: Consolidate Geneve functionality in single module.

2015-08-25 Thread Pravin Shelar
On Tue, Aug 25, 2015 at 11:19 AM, Thomas Graf wrote: > On 08/24/15 at 10:43am, Pravin B Shelar wrote: >> - if (ip_tunnel_collect_metadata() && geneve->collect_md) { >> + if (ip_tunnel_collect_metadata() || gs->collect_md) { > > OK, what I pointed out in patch 5 is fixed here. > right, I fo

Re: [PATCH v3 net-next 7/8] geneve: Consolidate Geneve functionality in single module.

2015-08-25 Thread Pravin Shelar
On Tue, Aug 25, 2015 at 12:03 PM, Jesse Gross wrote: > On Mon, Aug 24, 2015 at 10:43 AM, Pravin B Shelar wrote: >> diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c >> index c05bc13..8eb875d 100644 >> --- a/drivers/net/geneve.c >> +++ b/drivers/net/geneve.c >> @@ -492,36 +813,36 @@ static

Re: [PATCH v3 net-next 7/8] geneve: Consolidate Geneve functionality in single module.

2015-08-25 Thread Jesse Gross
On Mon, Aug 24, 2015 at 10:43 AM, Pravin B Shelar wrote: > diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c > index c05bc13..8eb875d 100644 > --- a/drivers/net/geneve.c > +++ b/drivers/net/geneve.c > @@ -492,36 +813,36 @@ static int geneve_configure(struct net *net, struct > net_device *d

Re: [PATCH v3 net-next 7/8] geneve: Consolidate Geneve functionality in single module.

2015-08-25 Thread Thomas Graf
On 08/24/15 at 10:43am, Pravin B Shelar wrote: > - if (ip_tunnel_collect_metadata() && geneve->collect_md) { > + if (ip_tunnel_collect_metadata() || gs->collect_md) { OK, what I pointed out in patch 5 is fixed here. Metadata bits look good. Acked-by: Thomas Graf -- To unsubscribe from t

[PATCH v3 net-next 7/8] geneve: Consolidate Geneve functionality in single module.

2015-08-24 Thread Pravin B Shelar
geneve_core module handles send and receive functionality. This way OVS could use the Geneve API. Now with use of tunnel meatadata mode OVS can directly use Geneve netdevice. So there is no need for separate module for Geneve. Following patch consolidates Geneve protocol processing in single module