Re: [PATCH v3 net-next 2/4] net: dsa: microchip: add MIB counter reading support

2019-02-21 Thread Florian Fainelli
On 2/21/19 2:03 PM, tristram...@microchip.com wrote: > From: Tristram Ha > > Add background MIB counter reading support. > > Port MIB counters should only be read when there is link. Otherwise it is > a waste of time as hardware never increases those counters. There are > exceptions as some sw

Re: [PATCH v3 net-next 2/4] net: dsa: microchip: add MIB counter reading support

2019-02-21 Thread Andrew Lunn
On Thu, Feb 21, 2019 at 02:03:15PM -0800, tristram...@microchip.com wrote: > From: Tristram Ha > > Add background MIB counter reading support. > > Port MIB counters should only be read when there is link. Otherwise it is > a waste of time as hardware never increases those counters. There are >

[PATCH v3 net-next 2/4] net: dsa: microchip: add MIB counter reading support

2019-02-21 Thread Tristram.Ha
From: Tristram Ha Add background MIB counter reading support. Port MIB counters should only be read when there is link. Otherwise it is a waste of time as hardware never increases those counters. There are exceptions as some switches keep track of dropped counts no matter what. Signed-off-by: