Re: [PATCH v3 net-next 14/14] dsa: Allow tag drivers to be built as modules

2019-04-27 Thread Florian Fainelli
On 4/27/2019 1:17 PM, Andrew Lunn wrote: > On Sat, Apr 27, 2019 at 12:32:28PM -0700, Randy Dunlap wrote: >> Hi Andrew, >> >> There is one typo below: >> >> On 4/27/19 10:00 AM, Andrew Lunn wrote: >> >>> config NET_DSA_TAG_TRAILER >>> - bool >>> - >>> -config NET_DSA_TAG_QCA >>> - bool >>> +

Re: [PATCH v3 net-next 14/14] dsa: Allow tag drivers to be built as modules

2019-04-27 Thread Andrew Lunn
On Sat, Apr 27, 2019 at 12:32:28PM -0700, Randy Dunlap wrote: > Hi Andrew, > > There is one typo below: > > On 4/27/19 10:00 AM, Andrew Lunn wrote: > > > config NET_DSA_TAG_TRAILER > > - bool > > - > > -config NET_DSA_TAG_QCA > > - bool > > + tristate "Tag driver for switches using a trai

Re: [PATCH v3 net-next 14/14] dsa: Allow tag drivers to be built as modules

2019-04-27 Thread Randy Dunlap
Hi Andrew, There is one typo below: On 4/27/19 10:00 AM, Andrew Lunn wrote: > config NET_DSA_TAG_TRAILER > - bool > - > -config NET_DSA_TAG_QCA > - bool > + tristate "Tag driver for switches using a trailler tag" trailer > + he

[PATCH v3 net-next 14/14] dsa: Allow tag drivers to be built as modules

2019-04-27 Thread Andrew Lunn
Make the CONFIG symbols tristate and add help text. The broadcom and Microchip KSZ tag drivers support two different tagging protocols in one driver. Add a configuration option for the drivers, and then options to select the protocol. Create a submenu for the tagging drivers. Signed-off-by: Andr