Re: [PATCH v3 net-next 06/21] nvme-tcp: Add DDP offload control path

2021-02-03 Thread Sagi Grimberg
On 2/1/21 2:04 AM, Boris Pismenny wrote: This commit introduces direct data placement offload to NVME TCP. There is a context per queue, which is established after the handshake using the tcp_ddp_sk_add/del NDOs. Additionally, a resynchronization routine is used to assist hardware recovery fr

Re: [PATCH v3 net-next 06/21] nvme-tcp: Add DDP offload control path

2021-02-02 Thread Or Gerlitz
On Mon, Feb 1, 2021 at 7:39 PM Christoph Hellwig wrote: >> +static >> +int nvme_tcp_offload_socket(struct nvme_tcp_queue *queue) > > Please use the same coding style as the rest of the file, and not some > weirdo version. ack

Re: [PATCH v3 net-next 06/21] nvme-tcp: Add DDP offload control path

2021-02-01 Thread Christoph Hellwig
> +static > +int nvme_tcp_offload_socket(struct nvme_tcp_queue *queue) Please use the same coding style as the rest of the file, and not some weirdo version.

[PATCH v3 net-next 06/21] nvme-tcp: Add DDP offload control path

2021-02-01 Thread Boris Pismenny
This commit introduces direct data placement offload to NVME TCP. There is a context per queue, which is established after the handshake using the tcp_ddp_sk_add/del NDOs. Additionally, a resynchronization routine is used to assist hardware recovery from TCP OOO, and continue the offload. Resynchr