Re: [PATCH v3 net-next] tcp: Remove use of daddr_cache in tracepoint

2017-10-19 Thread David Miller
From: David Ahern Date: Tue, 17 Oct 2017 13:09:33 -0700 > Running perf in one window to capture tcp_retransmit_skb tracepoint: > $ perf record -e tcp:tcp_retransmit_skb -a > > And causing a retransmission on an active TCP session (e.g., dropping > packets in the receiver, changing MTU on the

Re: [PATCH v3 net-next] tcp: Remove use of daddr_cache in tracepoint

2017-10-17 Thread Song Liu
> > Remove use of ipv6_pinfo in favor of data in sock_common. > > > > Fixes: e086101b150a ("tcp: add a tracepoint for tcp retransmission") > > Signed-off-by: David Ahern > > --- > > Reviewed-by: Eric Dumazet > Thanks David ! Tested-by: Song Liu

Re: [PATCH v3 net-next] tcp: Remove use of daddr_cache in tracepoint

2017-10-17 Thread Eric Dumazet
On Tue, 2017-10-17 at 13:09 -0700, David Ahern wrote: > Running perf in one window to capture tcp_retransmit_skb tracepoint: > $ perf record -e tcp:tcp_retransmit_skb -a > > And causing a retransmission on an active TCP session (e.g., dropping > packets in the receiver, changing MTU on the int

Re: [PATCH v3 net-next] tcp: Remove use of daddr_cache in tracepoint

2017-10-17 Thread Cong Wang
On Tue, Oct 17, 2017 at 1:09 PM, David Ahern wrote: > Running perf in one window to capture tcp_retransmit_skb tracepoint: > $ perf record -e tcp:tcp_retransmit_skb -a > > And causing a retransmission on an active TCP session (e.g., dropping > packets in the receiver, changing MTU on the inter

[PATCH v3 net-next] tcp: Remove use of daddr_cache in tracepoint

2017-10-17 Thread David Ahern
Running perf in one window to capture tcp_retransmit_skb tracepoint: $ perf record -e tcp:tcp_retransmit_skb -a And causing a retransmission on an active TCP session (e.g., dropping packets in the receiver, changing MTU on the interface to 500 and back to 1500) triggers a panic: [ 58.543144