Re: [PATCH v3 net-next] net/ipv6: Do not allow route add with a device that is down

2018-01-25 Thread David Miller
From: David Ahern Date: Wed, 24 Jan 2018 19:45:29 -0800 > IPv6 allows routes to be installed when the device is not up (admin up). > Worse, it does not mark it as LINKDOWN. IPv4 does not allow it and really > there is no reason for IPv6 to allow it, so check the flags and deny if > device is admi

Re: [PATCH v3 net-next] net/ipv6: Do not allow route add with a device that is down

2018-01-25 Thread Roopa Prabhu
On Wed, Jan 24, 2018 at 7:45 PM, David Ahern wrote: > IPv6 allows routes to be installed when the device is not up (admin up). > Worse, it does not mark it as LINKDOWN. IPv4 does not allow it and really > there is no reason for IPv6 to allow it, so check the flags and deny if > device is admin dow

Re: [PATCH v3 net-next] net/ipv6: Do not allow route add with a device that is down

2018-01-25 Thread Ido Schimmel
On Wed, Jan 24, 2018 at 07:45:29PM -0800, David Ahern wrote: > IPv6 allows routes to be installed when the device is not up (admin up). > Worse, it does not mark it as LINKDOWN. IPv4 does not allow it and really > there is no reason for IPv6 to allow it, so check the flags and deny if > device is a

[PATCH v3 net-next] net/ipv6: Do not allow route add with a device that is down

2018-01-24 Thread David Ahern
IPv6 allows routes to be installed when the device is not up (admin up). Worse, it does not mark it as LINKDOWN. IPv4 does not allow it and really there is no reason for IPv6 to allow it, so check the flags and deny if device is admin down. Signed-off-by: David Ahern --- v3 - moved err=-ENETDOWN