Re: [PATCH v3 net-next] mdio_bus: Issue GPIO RESET to PHYs.

2017-04-21 Thread Roger Quadros
Hi Florian, On 21/04/17 04:23, Florian Fainelli wrote: > Hi Roger, > > On 04/20/2017 07:11 AM, Roger Quadros wrote: >> Some boards [1] leave the PHYs at an invalid state >> during system power-up or reset thus causing unreliability >> issues with the PHY which manifests as PHY not being detected

Re: [PATCH v3 net-next] mdio_bus: Issue GPIO RESET to PHYs.

2017-04-20 Thread Andrew Lunn
> > + gpiod_set_value_cansleep(gpiod, 1); > > + udelay(bus->reset_delay_us); > > + gpiod_set_value_cansleep(gpiod, 0); > > Does that work even if the polarity of the reset line is active low? Hi Florian Yes, it does. The gpiod_ API takes care

Re: [PATCH v3 net-next] mdio_bus: Issue GPIO RESET to PHYs.

2017-04-20 Thread Florian Fainelli
Hi Roger, On 04/20/2017 07:11 AM, Roger Quadros wrote: > Some boards [1] leave the PHYs at an invalid state > during system power-up or reset thus causing unreliability > issues with the PHY which manifests as PHY not being detected > or link not functional. To fix this, these PHYs need to be RESE

Re: [PATCH v3 net-next] mdio_bus: Issue GPIO RESET to PHYs.

2017-04-20 Thread Andrew Lunn
On Thu, Apr 20, 2017 at 05:11:53PM +0300, Roger Quadros wrote: > Some boards [1] leave the PHYs at an invalid state > during system power-up or reset thus causing unreliability > issues with the PHY which manifests as PHY not being detected > or link not functional. To fix this, these PHYs need to

[PATCH v3 net-next] mdio_bus: Issue GPIO RESET to PHYs.

2017-04-20 Thread Roger Quadros
Some boards [1] leave the PHYs at an invalid state during system power-up or reset thus causing unreliability issues with the PHY which manifests as PHY not being detected or link not functional. To fix this, these PHYs need to be RESET via a GPIO connected to the PHY's RESET pin. Some boards have