Re: [PATCH v3 net] net: ipv6: regenerate host route if moved to gc list

2017-04-25 Thread Andrey Konovalov
On Tue, Apr 25, 2017 at 5:54 PM, David Ahern wrote: > On 4/25/17 6:50 AM, Andrey Konovalov wrote: >> I've been running syzkaller with your patch and got another report >> from ip6_pol_route. > > In general the existing patch cleans up all of the ipv6 fib kasan and > WARN_ON traces that were seen?

Re: [PATCH v3 net] net: ipv6: regenerate host route if moved to gc list

2017-04-25 Thread David Ahern
On 4/25/17 6:50 AM, Andrey Konovalov wrote: > I've been running syzkaller with your patch and got another report > from ip6_pol_route. In general the existing patch cleans up all of the ipv6 fib kasan and WARN_ON traces that were seen? > > It happened only once so far and I couldn't reproduce i

Re: [PATCH v3 net] net: ipv6: regenerate host route if moved to gc list

2017-04-25 Thread Andrey Konovalov
On Mon, Apr 24, 2017 at 5:09 PM, David Ahern wrote: > Taking down the loopback device wreaks havoc on IPv6 routing. By > extension, taking down a VRF device wreaks havoc on its table. > > Dmitry and Andrey both reported heap out-of-bounds reports in the IPv6 > FIB code while running syzkaller fuzz

Re: [PATCH v3 net] net: ipv6: regenerate host route if moved to gc list

2017-04-24 Thread Martin KaFai Lau
On Mon, Apr 24, 2017 at 01:37:00PM -0600, David Ahern wrote: > On 4/24/17 10:39 AM, Eric Dumazet wrote: > > > > Very nice changelog ! > > > Thanks. Given my aggressive brain cell recycling program, I needed to > write down the analysis. > > > > >> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrcon

Re: [PATCH v3 net] net: ipv6: regenerate host route if moved to gc list

2017-04-24 Thread David Ahern
On 4/24/17 10:39 AM, Eric Dumazet wrote: > > Very nice changelog ! Thanks. Given my aggressive brain cell recycling program, I needed to write down the analysis. >> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c >> index 80ce478c4851..93f81d9cd85f 100644 >> --- a/net/ipv6/addrconf.c >

Re: [PATCH v3 net] net: ipv6: regenerate host route if moved to gc list

2017-04-24 Thread Eric Dumazet
On Mon, 2017-04-24 at 08:09 -0700, David Ahern wrote: > Taking down the loopback device wreaks havoc on IPv6 routing. By > extension, taking down a VRF device wreaks havoc on its table. > > Dmitry and Andrey both reported heap out-of-bounds reports in the IPv6 > FIB code while running syzkaller fu

[PATCH v3 net] net: ipv6: regenerate host route if moved to gc list

2017-04-24 Thread David Ahern
Taking down the loopback device wreaks havoc on IPv6 routing. By extension, taking down a VRF device wreaks havoc on its table. Dmitry and Andrey both reported heap out-of-bounds reports in the IPv6 FIB code while running syzkaller fuzzer. The root cause is a dead dst that is on the garbage list g