Re: [PATCH v3 3/3] stmmac: adding new glue driver dwmac-dwc-qos-eth

2017-01-06 Thread Joao Pinto
Às 1:27 PM de 1/6/2017, Alexandre Torgue escreveu: > Hi Joao, > > On 01/05/2017 06:49 PM, Joao Pinto wrote: >> Hi Alex, >> >> Às 5:19 PM de 1/5/2017, Alexandre Torgue escreveu: >>> Hi Joao, >>> >>> On 01/04/2017 05:22 PM, Joao Pinto wrote: This patch adds a new glue driver called dwmac-dwc-qo

Re: [PATCH v3 3/3] stmmac: adding new glue driver dwmac-dwc-qos-eth

2017-01-06 Thread Alexandre Torgue
Hi Joao, On 01/05/2017 06:49 PM, Joao Pinto wrote: Hi Alex, Às 5:19 PM de 1/5/2017, Alexandre Torgue escreveu: Hi Joao, On 01/04/2017 05:22 PM, Joao Pinto wrote: This patch adds a new glue driver called dwmac-dwc-qos-eth which was based in the dwc_eth_qos as is. To assure retro-compatibility

Re: [PATCH v3 3/3] stmmac: adding new glue driver dwmac-dwc-qos-eth

2017-01-05 Thread Joao Pinto
Hi Alex, Às 5:19 PM de 1/5/2017, Alexandre Torgue escreveu: > Hi Joao, > > On 01/04/2017 05:22 PM, Joao Pinto wrote: >> This patch adds a new glue driver called dwmac-dwc-qos-eth which >> was based in the dwc_eth_qos as is. To assure retro-compatibility a slight >> tweak was also added to stmmac_

Re: [PATCH v3 3/3] stmmac: adding new glue driver dwmac-dwc-qos-eth

2017-01-05 Thread Alexandre Torgue
Hi Joao, On 01/04/2017 05:22 PM, Joao Pinto wrote: This patch adds a new glue driver called dwmac-dwc-qos-eth which was based in the dwc_eth_qos as is. To assure retro-compatibility a slight tweak was also added to stmmac_platform. Sorry to come late in the review. I have a basic question. Why

Re: [PATCH v3 3/3] stmmac: adding new glue driver dwmac-dwc-qos-eth

2017-01-05 Thread Lars Persson
> On 04 Jan 2017, at 17:22 , Joao Pinto wrote: > > This patch adds a new glue driver called dwmac-dwc-qos-eth which > was based in the dwc_eth_qos as is. To assure retro-compatibility a slight > tweak was also added to stmmac_platform. > > Signed-off-by: Joao Pinto > --- > changes v2 -> v3: >

Re: [PATCH v3 3/3] stmmac: adding new glue driver dwmac-dwc-qos-eth

2017-01-04 Thread Joao Pinto
Às 4:31 PM de 1/4/2017, Niklas Cassel escreveu: > I think you accidentally removed the Reviewed-by from Lars. I took it off because the driver was changed after the first review (v1->v2). Lars, could you please confirm that everything is fine for you? Thanks. > > On 01/04/2017 05:22 PM, Joao Pi

Re: [PATCH v3 3/3] stmmac: adding new glue driver dwmac-dwc-qos-eth

2017-01-04 Thread Niklas Cassel
I think you accidentally removed the Reviewed-by from Lars. On 01/04/2017 05:22 PM, Joao Pinto wrote: > This patch adds a new glue driver called dwmac-dwc-qos-eth which > was based in the dwc_eth_qos as is. To assure retro-compatibility a slight > tweak was also added to stmmac_platform. > > Signe

Re: [PATCH v3 3/3] stmmac: adding new glue driver dwmac-dwc-qos-eth

2017-01-04 Thread Niklas Cassel
Tested-by: Niklas Cassel On 01/04/2017 05:22 PM, Joao Pinto wrote: > This patch adds a new glue driver called dwmac-dwc-qos-eth which > was based in the dwc_eth_qos as is. To assure retro-compatibility a slight > tweak was also added to stmmac_platform. > > Signed-off-by: Joao Pinto > --- > chan

[PATCH v3 3/3] stmmac: adding new glue driver dwmac-dwc-qos-eth

2017-01-04 Thread Joao Pinto
This patch adds a new glue driver called dwmac-dwc-qos-eth which was based in the dwc_eth_qos as is. To assure retro-compatibility a slight tweak was also added to stmmac_platform. Signed-off-by: Joao Pinto --- changes v2 -> v3: - Nothing changed, just to keep up patch set version changes v1 -> v