Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: Don't force link when using in-band-status

2020-10-20 Thread Chris Packham
On 21/10/20 10:18 am, Russell King - ARM Linux admin wrote: > On Tue, Oct 20, 2020 at 09:06:32PM +, Chris Packham wrote: >> On 21/10/20 3:51 am, Marek Behun wrote: >>> On Tue, 20 Oct 2020 15:15:25 +0100 >>> Russell King - ARM Linux admin wrote: >>> On Tue, Oct 20, 2020 at 04:05:35PM +020

Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: Don't force link when using in-band-status

2020-10-20 Thread Russell King - ARM Linux admin
On Tue, Oct 20, 2020 at 09:06:32PM +, Chris Packham wrote: > > On 21/10/20 3:51 am, Marek Behun wrote: > > On Tue, 20 Oct 2020 15:15:25 +0100 > > Russell King - ARM Linux admin wrote: > > > >> On Tue, Oct 20, 2020 at 04:05:35PM +0200, Andrew Lunn wrote: > >>> On Tue, Oct 20, 2020 at 03:49:40P

Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: Don't force link when using in-band-status

2020-10-20 Thread Andrew Lunn
Hi Chris > So far I've not needed to use interrupts from the 6097. It's connected > on my hardware but never been tested. The mv88e6xxx driver will also poll the interrupt bits, if the interrupt is not wired to a GPIO. > There are a couple of SERDES LinkInt bits in the Global2 interrupt > sourc

Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: Don't force link when using in-band-status

2020-10-20 Thread Chris Packham
On 21/10/20 3:51 am, Marek Behun wrote: > On Tue, 20 Oct 2020 15:15:25 +0100 > Russell King - ARM Linux admin wrote: > >> On Tue, Oct 20, 2020 at 04:05:35PM +0200, Andrew Lunn wrote: >>> On Tue, Oct 20, 2020 at 03:49:40PM +0200, Marek Behun wrote: On Tue, 20 Oct 2020 11:15:52 +0100 Russ

Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: Don't force link when using in-band-status

2020-10-20 Thread Chris Packham
On 21/10/20 3:58 am, Andrew Lunn wrote: >>> It's still there. The speed/duplex etc are read from the serdes PHY >>> via mv88e6390_serdes_pcs_get_state(). When the link comes up, we >>> pass the negotiated link parameters read from there to the link_up() >>> functions. For ports where mv88e6xxx_por

Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: Don't force link when using in-band-status

2020-10-20 Thread Andrew Lunn
> > It's still there. The speed/duplex etc are read from the serdes PHY > > via mv88e6390_serdes_pcs_get_state(). When the link comes up, we > > pass the negotiated link parameters read from there to the link_up() > > functions. For ports where mv88e6xxx_port_ppu_updates() returns false > > (no ext

Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: Don't force link when using in-band-status

2020-10-20 Thread Marek Behun
On Tue, 20 Oct 2020 15:15:25 +0100 Russell King - ARM Linux admin wrote: > On Tue, Oct 20, 2020 at 04:05:35PM +0200, Andrew Lunn wrote: > > On Tue, Oct 20, 2020 at 03:49:40PM +0200, Marek Behun wrote: > > > On Tue, 20 Oct 2020 11:15:52 +0100 > > > Russell King - ARM Linux admin wrote: > > >

Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: Don't force link when using in-band-status

2020-10-20 Thread Russell King - ARM Linux admin
On Tue, Oct 20, 2020 at 04:05:35PM +0200, Andrew Lunn wrote: > On Tue, Oct 20, 2020 at 03:49:40PM +0200, Marek Behun wrote: > > On Tue, 20 Oct 2020 11:15:52 +0100 > > Russell King - ARM Linux admin wrote: > > > > > On Tue, Oct 20, 2020 at 04:45:56PM +1300, Chris Packham wrote: > > > > When a port

Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: Don't force link when using in-band-status

2020-10-20 Thread Andrew Lunn
On Tue, Oct 20, 2020 at 03:49:40PM +0200, Marek Behun wrote: > On Tue, 20 Oct 2020 11:15:52 +0100 > Russell King - ARM Linux admin wrote: > > > On Tue, Oct 20, 2020 at 04:45:56PM +1300, Chris Packham wrote: > > > When a port is configured with 'managed = "in-band-status"' don't force > > > the li

Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: Don't force link when using in-band-status

2020-10-20 Thread Marek Behun
On Tue, 20 Oct 2020 11:15:52 +0100 Russell King - ARM Linux admin wrote: > On Tue, Oct 20, 2020 at 04:45:56PM +1300, Chris Packham wrote: > > When a port is configured with 'managed = "in-band-status"' don't force > > the link up, the switch MAC will detect the link status correctly. > > > > Sig

Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: Don't force link when using in-band-status

2020-10-20 Thread Russell King - ARM Linux admin
On Tue, Oct 20, 2020 at 04:45:56PM +1300, Chris Packham wrote: > When a port is configured with 'managed = "in-band-status"' don't force > the link up, the switch MAC will detect the link status correctly. > > Signed-off-by: Chris Packham > Reviewed-by: Andrew Lunn I thought we had issues with

[PATCH v3 1/3] net: dsa: mv88e6xxx: Don't force link when using in-band-status

2020-10-19 Thread Chris Packham
When a port is configured with 'managed = "in-band-status"' don't force the link up, the switch MAC will detect the link status correctly. Signed-off-by: Chris Packham Reviewed-by: Andrew Lunn --- Changes in v3: - None Changes in v2: - Add review from Andrew drivers/net/dsa/mv88e6xxx/chip.c |