Re: [PATCH v3] net: phylink: correct trivial kernel-doc inconsistencies

2020-06-29 Thread David Miller
From: Russell King - ARM Linux admin Date: Sun, 28 Jun 2020 23:20:36 +0100 > On Sun, Jun 28, 2020 at 09:36:35PM +, Colton Lewis wrote: >> > We seem to be having a communication breakdown. In review to your >> > version 2 patch set, I said: >> > >> >However, please drop all your changes

Re: [PATCH v3] net: phylink: correct trivial kernel-doc inconsistencies

2020-06-28 Thread Russell King - ARM Linux admin
On Sun, Jun 28, 2020 at 09:36:35PM +, Colton Lewis wrote: > > We seem to be having a communication breakdown. In review to your > > version 2 patch set, I said: > > > >However, please drop all your changes for everything but the > >"struct phylink_config" documentation change; I'm int

Re: [PATCH v3] net: phylink: correct trivial kernel-doc inconsistencies

2020-06-28 Thread Colton Lewis
> We seem to be having a communication breakdown. In review to your > version 2 patch set, I said: > >However, please drop all your changes for everything but the >"struct phylink_config" documentation change; I'm intending to change >all these method signatures, which means your chan

Re: [PATCH v3] net: phylink: correct trivial kernel-doc inconsistencies

2020-06-28 Thread Russell King - ARM Linux admin
On Sat, Jun 27, 2020 at 11:58:09PM +, Colton Lewis wrote: > Silence documentation build warnings by correcting kernel-doc > comments. In the case of pcs_{config,an_restart,link_up}, change the > declaration to a normal function since these only there for > documentation anyway. > > ./include/l

[PATCH v3] net: phylink: correct trivial kernel-doc inconsistencies

2020-06-27 Thread Colton Lewis
Silence documentation build warnings by correcting kernel-doc comments. In the case of pcs_{config,an_restart,link_up}, change the declaration to a normal function since these only there for documentation anyway. ./include/linux/phylink.h:74: warning: Function parameter or member 'poll_fixed_stat