RE: [PATCH v3] net: e1000e: add MAC address kernel cmd line parameter

2019-03-01 Thread Flavio Suligoi
> >> > Hi Flavio > >> > > >> > u-boot should be able to write the MAC address in the correct part of > >> > device tree. Boards have been doing this a long time. > >> > > >> > Module parameters are considered bad. You should only do it if you > >> > have no other option. Here you do have another op

Re: [PATCH v3] net: e1000e: add MAC address kernel cmd line parameter

2019-02-28 Thread David Miller
From: Andrew Lunn Date: Thu, 28 Feb 2019 20:29:58 +0100 > On Thu, Feb 28, 2019 at 05:13:27PM +, Flavio Suligoi wrote: >> > > Hi Andrew, >> > > >> > > we produce a lot of boards and we have to change the MAC address, >> > > from u-boot, for every board. So I must save in the u-boot >> > > env

Re: [PATCH v3] net: e1000e: add MAC address kernel cmd line parameter

2019-02-28 Thread Andrew Lunn
On Thu, Feb 28, 2019 at 05:13:27PM +, Flavio Suligoi wrote: > > > Hi Andrew, > > > > > > we produce a lot of boards and we have to change the MAC address, > > > from u-boot, for every board. So I must save in the u-boot > > > environment (SPI NOR flash) the MAC address for every board. > > >

RE: [PATCH v3] net: e1000e: add MAC address kernel cmd line parameter

2019-02-28 Thread Flavio Suligoi
> > Hi Andrew, > > > > we produce a lot of boards and we have to change the MAC address, > > from u-boot, for every board. So I must save in the u-boot > > environment (SPI NOR flash) the MAC address for every board. > > Hi Flavio > > u-boot should be able to write the MAC address in the correct

Re: [PATCH v3] net: e1000e: add MAC address kernel cmd line parameter

2019-02-28 Thread Andrew Lunn
> Hi Andrew, > > we produce a lot of boards and we have to change the MAC address, > from u-boot, for every board. So I must save in the u-boot > environment (SPI NOR flash) the MAC address for every board. Hi Flavio u-boot should be able to write the MAC address in the correct part of device t

Re: [PATCH v3] net: e1000e: add MAC address kernel cmd line parameter

2019-02-28 Thread Flavio Suligoi
> -Original Message- > From: Andrew Lunn > Sent: giovedì 28 febbraio 2019 16:33 > To: Flavio Suligoi > Cc: Jeff Kirsher ; David S . Miller > ; intel-wired-...@lists.osuosl.org; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org > Subject: Re: [PATCH v3] net:

Re: [PATCH v3] net: e1000e: add MAC address kernel cmd line parameter

2019-02-28 Thread Andrew Lunn
On Thu, Feb 28, 2019 at 02:52:31PM +0100, Flavio Suligoi wrote: > Sometimes, in some embedded systems boards (i.e. ARM boards), > the NVM eeprom is not mounted, to save cost and space. > > In this case it is necessary to bypass the NVM management > and directly force the MAC address using a kernel

[PATCH v3] net: e1000e: add MAC address kernel cmd line parameter

2019-02-28 Thread Flavio Suligoi
Sometimes, in some embedded systems boards (i.e. ARM boards), the NVM eeprom is not mounted, to save cost and space. In this case it is necessary to bypass the NVM management and directly force the MAC address using a kernel command-line parameter (macaddr). Signed-off-by: Flavio Suligoi --- v3