Re: [PATCH v3] net: Add trace events for all receive exit points

2018-11-19 Thread Geneviève Bastien
On 2018-11-19 10:27 a.m., Geneviève Bastien wrote: > On 2018-11-18 1:19 a.m., David Miller wrote: >> From: Mathieu Desnoyers >> Date: Sat, 17 Nov 2018 13:27:29 -0500 (EST) >> >>> I see two possible solutions: >>> >>> 1) Remove the "skb" argument from the sbk_exit tracepoints completely. >>> Anyw

Re: [PATCH v3] net: Add trace events for all receive exit points

2018-11-19 Thread Geneviève Bastien
On 2018-11-18 1:19 a.m., David Miller wrote: > From: Mathieu Desnoyers > Date: Sat, 17 Nov 2018 13:27:29 -0500 (EST) > >> I see two possible solutions: >> >> 1) Remove the "skb" argument from the sbk_exit tracepoints completely. >> Anyway, I think it's not really needed for analysis purposes bec

Re: [PATCH v3] net: Add trace events for all receive exit points

2018-11-17 Thread David Miller
From: Mathieu Desnoyers Date: Sat, 17 Nov 2018 13:27:29 -0500 (EST) > I see two possible solutions: > > 1) Remove the "skb" argument from the sbk_exit tracepoints completely. > Anyway, I think it's not really needed for analysis purposes because > we can link the "entry" with the associated "exi

Re: [PATCH v3] net: Add trace events for all receive exit points

2018-11-17 Thread Mathieu Desnoyers
- On Nov 16, 2018, at 10:50 PM, David S. Miller da...@davemloft.net wrote: > From: Geneviève Bastien > Date: Tue, 13 Nov 2018 15:13:26 -0500 > >> @@ -5222,9 +5228,14 @@ static void netif_receive_skb_list_internal(struct >> list_head *head) >> */ >> int netif_receive_skb(struct sk_buff *sk

Re: [PATCH v3] net: Add trace events for all receive exit points

2018-11-16 Thread David Miller
From: Geneviève Bastien Date: Tue, 13 Nov 2018 15:13:26 -0500 > @@ -5222,9 +5228,14 @@ static void netif_receive_skb_list_internal(struct > list_head *head) > */ > int netif_receive_skb(struct sk_buff *skb) > { > + int ret; > + > trace_netif_receive_skb_entry(skb); > > - retu

[PATCH v3] net: Add trace events for all receive exit points

2018-11-13 Thread Geneviève Bastien
Trace events are already present for the receive entry points, to indicate how the reception entered the stack. This patch adds the corresponding exit trace events that will bound the reception such that all events occurring between the entry and the exit can be considered as part of the reception