Re: [EXT] Re: [PATCH v3] aquantia: Remove the build_skb path

2020-11-24 Thread Igor Russkikh
>> >> Since normal layout is 1400 packets - we do use 2K (half page) for each > packet. > > What is 'normal layout is 1400 packets' ? Didn't you mean the 1500 byte > standard MTU? So this is what you've been trying to tell me - that for > 1500 byte mtu and 1k HW granularity you need to provide t

Re: [EXT] Re: [PATCH v3] aquantia: Remove the build_skb path

2020-11-23 Thread Maciej Fijalkowski
On Fri, Nov 20, 2020 at 11:18:34AM +0300, Igor Russkikh wrote: > > > On 20/11/2020 1:49 am, Maciej Fijalkowski wrote: > > External Email > > > > -- > > On Thu, Nov 19, 2020 at 10:34:48PM +, Ramsay, Lincoln wrote: > >> When p

Re: [EXT] Re: [PATCH v3] aquantia: Remove the build_skb path

2020-11-20 Thread Igor Russkikh
On 20/11/2020 1:49 am, Maciej Fijalkowski wrote: > External Email > > -- > On Thu, Nov 19, 2020 at 10:34:48PM +, Ramsay, Lincoln wrote: >> When performing IPv6 forwarding, there is an expectation that SKBs >> will have some

Re: [PATCH v3] aquantia: Remove the build_skb path

2020-11-19 Thread Florian Westphal
Ramsay, Lincoln wrote: > When performing IPv6 forwarding, there is an expectation that SKBs > will have some headroom. When forwarding a packet from the aquantia > driver, this does not always happen, triggering a kernel warning. > > The build_skb path fails to allow for an SKB header, but the ha

Re: [PATCH v3] aquantia: Remove the build_skb path

2020-11-19 Thread Maciej Fijalkowski
On Thu, Nov 19, 2020 at 10:34:48PM +, Ramsay, Lincoln wrote: > When performing IPv6 forwarding, there is an expectation that SKBs > will have some headroom. When forwarding a packet from the aquantia > driver, this does not always happen, triggering a kernel warning. > > The build_skb path fai

[PATCH v3] aquantia: Remove the build_skb path

2020-11-19 Thread Ramsay, Lincoln
When performing IPv6 forwarding, there is an expectation that SKBs will have some headroom. When forwarding a packet from the aquantia driver, this does not always happen, triggering a kernel warning. The build_skb path fails to allow for an SKB header, but the hardware buffer it is built around w