Re: [PATCH v3] Revert "virtio-net: ethtool configurable RXCSUM"

2020-10-21 Thread Michael S. Tsirkin
On Wed, Oct 21, 2020 at 10:18:20AM -0400, Willem de Bruijn wrote: > On Wed, Oct 21, 2020 at 8:00 AM Michael S. Tsirkin wrote: > > > > This reverts commit 3618ad2a7c0e78e4258386394d5d5f92a3dbccf8. > > > > When control vq is not negotiated, that commit causes a crash: > > > > [ 72.229171] kernel B

Re: [PATCH v3] Revert "virtio-net: ethtool configurable RXCSUM"

2020-10-21 Thread Willem de Bruijn
On Wed, Oct 21, 2020 at 8:00 AM Michael S. Tsirkin wrote: > > This reverts commit 3618ad2a7c0e78e4258386394d5d5f92a3dbccf8. > > When control vq is not negotiated, that commit causes a crash: > > [ 72.229171] kernel BUG at drivers/net/virtio_net.c:1667! > [ 72.230266] invalid opcode: [#1]

[PATCH v3] Revert "virtio-net: ethtool configurable RXCSUM"

2020-10-21 Thread Michael S. Tsirkin
This reverts commit 3618ad2a7c0e78e4258386394d5d5f92a3dbccf8. When control vq is not negotiated, that commit causes a crash: [ 72.229171] kernel BUG at drivers/net/virtio_net.c:1667! [ 72.230266] invalid opcode: [#1] PREEMPT SMP [ 72.231172] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5