pradeep singh wrote:
Hi,
This is second submission for a possible NULL dereference handling in
the Chelsio's 10G driver.
Thanks to Jens Axboe for pointing out my mistake of ignoring
subsequent dereferences in init_one routine.
Thanks
Signed-off-by: Pradeep Singh <[EMAIL PROTECTED]>
---
drivers
Andrew Morton wrote:
On Mon, 25 Jun 2007 19:14:05 -0400
Jeff Garzik <[EMAIL PROTECTED]> wrote:
> Andrew Morton wrote:
> > The chelsio driver is assuming that pci_device_id.driver_data has been
> > initialised to the board index, but I am unable to locate anywhere
where
> > that initialisation
On Mon, 25 Jun 2007 19:15:39 -0400
Jeff Garzik <[EMAIL PROTECTED]> wrote:
> Andrew Morton wrote:
> > (Who maintains this driver now?)
>
>
> It was abandonware from the beginning of its life. Stephen H and
> Francois R did a bunch of cleanups most recently.
>
> Jeff
Have a couple of loa
Andrew Morton wrote:
On Mon, 25 Jun 2007 19:14:05 -0400
Jeff Garzik <[EMAIL PROTECTED]> wrote:
Andrew Morton wrote:
The chelsio driver is assuming that pci_device_id.driver_data has been
initialised to the board index, but I am unable to locate anywhere where
that initialisation actually happe
On Mon, 25 Jun 2007 19:14:05 -0400
Jeff Garzik <[EMAIL PROTECTED]> wrote:
> Andrew Morton wrote:
> > The chelsio driver is assuming that pci_device_id.driver_data has been
> > initialised to the board index, but I am unable to locate anywhere where
> > that initialisation actually happens.
>
> It
Andrew Morton wrote:
(Who maintains this driver now?)
It was abandonware from the beginning of its life. Stephen H and
Francois R did a bunch of cleanups most recently.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PRO
Andrew Morton wrote:
The chelsio driver is assuming that pci_device_id.driver_data has been
initialised to the board index, but I am unable to locate anywhere where
that initialisation actually happens.
It's hidden inside the CH_DEVICE() initializer-helper macro.
Jeff
-
To unsubscrib
On Thu, 21 Jun 2007 18:48:30 +0530
"pradeep singh" <[EMAIL PROTECTED]> wrote:
> diff --git a/drivers/net/chelsio/cxgb2.c b/drivers/net/chelsio/cxgb2.c
> index 231ce43..006c634 100644
> --- a/drivers/net/chelsio/cxgb2.c
> +++ b/drivers/net/chelsio/cxgb2.c
> @@ -1022,6 +1022,11 @@ static int __devin
On 6/23/07, Andrew Morton <[EMAIL PROTECTED]> wrote:
> On Thu, 21 Jun 2007 18:48:30 +0530 "pradeep singh" <[EMAIL PROTECTED]> wrote:
> Hi,
> My mistake.
> Resending after reformatting the patch by hand.
> Looks like gmail messes the plain text patches.
>
That's still mangled so I typed it in aga
> On Thu, 21 Jun 2007 18:48:30 +0530 "pradeep singh" <[EMAIL PROTECTED]> wrote:
> Hi,
> My mistake.
> Resending after reformatting the patch by hand.
> Looks like gmail messes the plain text patches.
>
That's still mangled so I typed it in again.
Please always include a full changlog with each v
Hi,
My mistake.
Resending after reformatting the patch by hand.
Looks like gmail messes the plain text patches.
Thanks
Signed-off-by: Pradeep Singh <[EMAIL PROTECTED]>
---
drivers/net/chelsio/cxgb2.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/net/chelsio/
On 6/21/07, pradeep singh <[EMAIL PROTECTED]> wrote:
Hi,
This is second submission for a possible NULL dereference handling in
the Chelsio's 10G driver.
Thanks to Jens Axboe for pointing out my mistake of ignoring
subsequent dereferences in init_one routine.
Thanks
Apologies, looks like patch
Hi,
This is second submission for a possible NULL dereference handling in
the Chelsio's 10G driver.
Thanks to Jens Axboe for pointing out my mistake of ignoring
subsequent dereferences in init_one routine.
Thanks
Signed-off-by: Pradeep Singh <[EMAIL PROTECTED]>
---
drivers/net/chelsio/cxgb2.c |
On 6/21/07, Jens Axboe <[EMAIL PROTECTED]> wrote:
On Thu, Jun 21 2007, pradeep singh wrote:
> Hi
> On 6/21/07, Jens Axboe <[EMAIL PROTECTED]> wrote:
> >On Thu, Jun 21 2007, pradeep singh wrote:
> >> Hi,
> >>
> >> Chelsio's in kernel 10G driver does not checks the return value from
> >> t1_get_boa
On Thu, Jun 21 2007, pradeep singh wrote:
> Hi
> On 6/21/07, Jens Axboe <[EMAIL PROTECTED]> wrote:
> >On Thu, Jun 21 2007, pradeep singh wrote:
> >> Hi,
> >>
> >> Chelsio's in kernel 10G driver does not checks the return value from
> >> t1_get_board_info() in cxgb2.c.
> >> t1_get_board_info may ret
Hi
On 6/21/07, Jens Axboe <[EMAIL PROTECTED]> wrote:
On Thu, Jun 21 2007, pradeep singh wrote:
> Hi,
>
> Chelsio's in kernel 10G driver does not checks the return value from
> t1_get_board_info() in cxgb2.c.
> t1_get_board_info may return a NULL and we still go on to dereference
> it in the for l
On Thu, Jun 21 2007, pradeep singh wrote:
> Hi,
>
> Chelsio's in kernel 10G driver does not checks the return value from
> t1_get_board_info() in cxgb2.c.
> t1_get_board_info may return a NULL and we still go on to dereference
> it in the for loop without checking for the NULL.
>
> This patch fix
Hi,
Chelsio's in kernel 10G driver does not checks the return value from
t1_get_board_info() in cxgb2.c.
t1_get_board_info may return a NULL and we still go on to dereference
it in the for loop without checking for the NULL.
This patch fixes this.
Signed-off-by: Pradeep Singh <[EMAIL PROTECTED]
18 matches
Mail list logo
