Re: [PATCH v2 net-next 3/3] octeontx2-af: Add devlink health reporters for NIX

2020-11-07 Thread Sunil Kovvuri
On Sat, Nov 7, 2020 at 2:28 AM Saeed Mahameed wrote: > > On Fri, 2020-11-06 at 00:59 +0530, Sunil Kovvuri wrote: > > > > > > Output: > > > > > > # ./devlink health > > > > > > pci/0002:01:00.0: > > > > > >reporter npa > > > > > > state healthy error 0 recover 0 > > > > > >reporter n

Re: [PATCH v2 net-next 3/3] octeontx2-af: Add devlink health reporters for NIX

2020-11-06 Thread Saeed Mahameed
On Fri, 2020-11-06 at 00:59 +0530, Sunil Kovvuri wrote: > > > > > Output: > > > > > # ./devlink health > > > > > pci/0002:01:00.0: > > > > >reporter npa > > > > > state healthy error 0 recover 0 > > > > >reporter nix > > > > > state healthy error 0 recover 0 > > > > > # ./devli

Re: [PATCH v2 net-next 3/3] octeontx2-af: Add devlink health reporters for NIX

2020-11-05 Thread Jakub Kicinski
On Thu, 05 Nov 2020 15:52:32 -0800 Saeed Mahameed wrote: > On Thu, 2020-11-05 at 12:42 -0800, Jakub Kicinski wrote: > > On Thu, 05 Nov 2020 11:23:54 -0800 Saeed Mahameed wrote: > > > If you report an error without recovering, devlink health will > > > report a > > > bad device state > > > > > >

Re: [PATCH v2 net-next 3/3] octeontx2-af: Add devlink health reporters for NIX

2020-11-05 Thread Saeed Mahameed
On Thu, 2020-11-05 at 12:42 -0800, Jakub Kicinski wrote: > On Thu, 05 Nov 2020 11:23:54 -0800 Saeed Mahameed wrote: > > If you report an error without recovering, devlink health will > > report a > > bad device state > > > > $ ./devlink health > >pci/0002:01:00.0: > > reporter npa > >

Re: [PATCH v2 net-next 3/3] octeontx2-af: Add devlink health reporters for NIX

2020-11-05 Thread Jakub Kicinski
On Thu, 05 Nov 2020 11:23:54 -0800 Saeed Mahameed wrote: > If you report an error without recovering, devlink health will report a > bad device state > > $ ./devlink health >pci/0002:01:00.0: > reporter npa >state error error 1 recover 0 Actually, the counter in the driver is unn

Re: [PATCH v2 net-next 3/3] octeontx2-af: Add devlink health reporters for NIX

2020-11-05 Thread Sunil Kovvuri
> > > > Output: > > > > # ./devlink health > > > > pci/0002:01:00.0: > > > >reporter npa > > > > state healthy error 0 recover 0 > > > >reporter nix > > > > state healthy error 0 recover 0 > > > > # ./devlink health dump show pci/0002:01:00.0 reporter nix > > > > NIX_AF_GENE

Re: [PATCH v2 net-next 3/3] octeontx2-af: Add devlink health reporters for NIX

2020-11-05 Thread Saeed Mahameed
On Thu, 2020-11-05 at 09:07 -0800, Jakub Kicinski wrote: > On Thu, 5 Nov 2020 13:36:56 + George Cherian wrote: > > > Now i am a little bit skeptic here, devlink health reporter > > > infrastructure was > > > never meant to deal with dump op only, the main purpose is to > > > diagnose/dump and r

Re: [PATCH v2 net-next 3/3] octeontx2-af: Add devlink health reporters for NIX

2020-11-05 Thread Saeed Mahameed
; linux-ker...@vger.kernel.org; Jiri Pirko > > Cc: k...@kernel.org; da...@davemloft.net; Sunil Kovvuri Goutham > > ; Linu Cherian ; > > Geethasowjanya Akula ; masahi...@kernel.org; > > willemdebruijn.ker...@gmail.com > > Subject: Re: [PATCH v2 net-next 3/3] octeontx2-a

Re: [PATCH v2 net-next 3/3] octeontx2-af: Add devlink health reporters for NIX

2020-11-05 Thread Jakub Kicinski
On Thu, 5 Nov 2020 13:36:56 + George Cherian wrote: > > Now i am a little bit skeptic here, devlink health reporter infrastructure > > was > > never meant to deal with dump op only, the main purpose is to > > diagnose/dump and recover. > > > > especially in your use case where you only report

Re: [PATCH v2 net-next 3/3] octeontx2-af: Add devlink health reporters for NIX

2020-11-05 Thread George Cherian
i Goutham > ; Linu Cherian ; > Geethasowjanya Akula ; masahi...@kernel.org; > willemdebruijn.ker...@gmail.com > Subject: Re: [PATCH v2 net-next 3/3] octeontx2-af: Add devlink health > reporters for NIX > > On Wed, 2020-11-04 at 17:57 +0530, George Cherian wrote: >

Re: [PATCH v2 net-next 3/3] octeontx2-af: Add devlink health reporters for NIX

2020-11-04 Thread Saeed Mahameed
On Wed, 2020-11-04 at 17:57 +0530, George Cherian wrote: > Add health reporters for RVU NPA block. ^^^ NIX ? Cc: Jiri Anyway, could you please spare some words on what is NPA and what is NIX? Regarding the reporters names, all drivers register well known generic n

[PATCH v2 net-next 3/3] octeontx2-af: Add devlink health reporters for NIX

2020-11-04 Thread George Cherian
Add health reporters for RVU NPA block. Only reporter dump is supported. Output: # ./devlink health pci/0002:01:00.0: reporter npa state healthy error 0 recover 0 reporter nix state healthy error 0 recover 0 # ./devlink health dump show pci/0002:01:00.0 reporter nix NIX_AF_GE