Re: [PATCH v2 net-next 2/2] mptcp: move recbuf adjustment to recvmsg path

2020-05-27 Thread Florian Westphal
Christoph Paasch wrote: > tcp_rcv_space_adjust is called even when the app is not yet reading, > thus wouldn't this mean that we still end up with an ever-growing > window? Window is based on available mptcp sk recvbuf. When data is moved from ssk to the mptcp sk, the skb truesize is charged to

Re: [PATCH v2 net-next 2/2] mptcp: move recbuf adjustment to recvmsg path

2020-05-26 Thread Christoph Paasch
Hello, On Mon, May 25, 2020 at 3:19 PM Florian Westphal wrote: > > From: Paolo Abeni > > Place receive window tuning in the recvmsg path. > This makes sure the size is only increased when userspace consumes data. > > Previously we would grow the sk receive buffer towards tcp_rmem[2], now we > so

[PATCH v2 net-next 2/2] mptcp: move recbuf adjustment to recvmsg path

2020-05-25 Thread Florian Westphal
From: Paolo Abeni Place receive window tuning in the recvmsg path. This makes sure the size is only increased when userspace consumes data. Previously we would grow the sk receive buffer towards tcp_rmem[2], now we so only if userspace reads data. Simply adjust the msk rcvbuf size to the larges