Re: [PATCH v2 net-next 14/14] mlx4: remove duplicate code in mlx4_en_process_rx_cq()

2017-02-09 Thread Eric Dumazet
On Thu, Feb 9, 2017 at 9:15 AM, Saeed Mahameed wrote: > On Thu, Feb 9, 2017 at 3:58 PM, Eric Dumazet wrote: >> We should keep one way to build skbs, regardless of GRO being on or off. >> >> Note that I made sure to defer as much as possible the point we need to >> pull data from the frame, so tha

Re: [PATCH v2 net-next 14/14] mlx4: remove duplicate code in mlx4_en_process_rx_cq()

2017-02-09 Thread Saeed Mahameed
On Thu, Feb 9, 2017 at 3:58 PM, Eric Dumazet wrote: > We should keep one way to build skbs, regardless of GRO being on or off. > > Note that I made sure to defer as much as possible the point we need to > pull data from the frame, so that future prefetch() we might add > are more effective. > > Th

[PATCH v2 net-next 14/14] mlx4: remove duplicate code in mlx4_en_process_rx_cq()

2017-02-09 Thread Eric Dumazet
We should keep one way to build skbs, regardless of GRO being on or off. Note that I made sure to defer as much as possible the point we need to pull data from the frame, so that future prefetch() we might add are more effective. These skb attributes derive from the CQE or ring : ip_summed, csum